Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC 2/2] ASoC: tlv320dac33: Request for reordered update power sequence
Date: Fri, 3 Dec 2010 11:36:27 +0200	[thread overview]
Message-ID: <201012031136.27104.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101202131505.GE859@rakim.wolfsonmicro.main>

On Thursday 02 December 2010 15:15:06 ext Mark Brown wrote:
> On Thu, Dec 02, 2010 at 02:52:04PM +0200, Peter Ujfalusi wrote:
> > Back to the naming.. What about reorder_dapm_update_power, and move the
> > flag to the snd_soc_dapm_widget struct?
> 
> If we're going down this route I'd rather have a name that reflected the
> new ordering rather than the fact that there's an ordering change.  Not
> that any ideas occur to me right now.

How about:
route_change_before_powerup

A bit long, but this describes well the meaning.

I think it is kind of silly to have a function, which just sets this flag, and I 
think having yet another DAPM widgets for this type is again a bad idea.
Do we have helper function, which can find a widget by name, and return the 
pointer to the snd_soc_dapm_widget?
I think if we have that, drivers can use that to get the widget they want to 
change the power up order, and set this flag.
If we ever need other new flags for widgets, this can be used for that purpose.
We could have an inline function, which uses the dapm_find_widget(), and sets 
the flag, to minimize duplicated code all over the place.

So I can move the flag per widget, and we are going to have pretty interface 
too.

What do you think?

-- 
Péter

  reply	other threads:[~2010-12-03  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 12:03 [RFC 0/2] ASoC: core: Option to reorder widget power sequence Peter Ujfalusi
2010-12-02 12:03 ` [RFC 1/2] ASoC: core: Reordered DAPM update power on widgets Peter Ujfalusi
2010-12-02 12:21   ` Mark Brown
2010-12-02 12:54     ` Peter Ujfalusi
2010-12-02 12:03 ` [RFC 2/2] ASoC: tlv320dac33: Request for reordered update power sequence Peter Ujfalusi
2010-12-02 12:24   ` Mark Brown
2010-12-02 12:52     ` Peter Ujfalusi
2010-12-02 13:15       ` Mark Brown
2010-12-03  9:36         ` Peter Ujfalusi [this message]
2010-12-02 13:05 ` [RFC 0/2] ASoC: core: Option to reorder widget " Mark Brown
2010-12-03  7:33   ` Peter Ujfalusi
2010-12-03 14:48     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012031136.27104.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox