From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 08/13] ASoC: Track which components have been registered with snd_soc_register_component()
Date: Mon, 24 Mar 2014 11:33:30 +0000 [thread overview]
Message-ID: <20140324113330.GI2269@sirena.org.uk> (raw)
In-Reply-To: <20140324111805.GI1665@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 966 bytes --]
On Mon, Mar 24, 2014 at 11:18:05AM +0000, Charles Keepax wrote:
> On Tue, Mar 18, 2014 at 09:02:11AM +0100, Lars-Peter Clausen wrote:
> > snd_soc_unregister_component() takes the parent device of the component as a
> > parameter and then looks up the component based on this. This is a problem if
> > multiple components are registered for the same parent device. Currently drivers
> Do we have any thoughts on what might be a longer term solution
> here? Is the parent device actually the right thing to pass to
> snd_soc_unregister_component, it feels like that is probably not
> going to be enough to accurately identify the component?
It's not clear to me that in the longer term it makes sense for anything
that is a single struct device to be registering multiple components in
the first place. In the short term we register things separately so it
makes sense to continue to support that to ease transition but it's not
clear to me that it's a good idea.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-24 11:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 8:02 [PATCH 00/13] ASoC: Move IO and kcontrols to the component level Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 01/13] ASoC: Add snd_soc_kcontrol_codec() helper function Lars-Peter Clausen
2014-03-24 10:57 ` Charles Keepax
2014-03-18 8:02 ` [PATCH 02/13] ASoC: Add snd_soc_kcontrol_platform() " Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 03/13] ASoC: Prepare SOC_SINGLE_XR_SX controls for regmap Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 04/13] ASoC: Move IO functions to soc-io.c Lars-Peter Clausen
2014-03-19 11:10 ` Mark Brown
2014-03-19 11:47 ` Lars-Peter Clausen
2014-03-19 11:53 ` Mark Brown
2014-03-19 11:57 ` Lars-Peter Clausen
2014-03-19 12:01 ` Mark Brown
2014-03-19 12:11 ` Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 05/13] ASoC: Drop ASoC level caching from hw_write/hw_read Lars-Peter Clausen
2014-03-19 12:58 ` Mark Brown
2014-03-19 13:01 ` Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 06/13] ASoC: Remove IO register modifier callbacks Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 07/13] ASoC: Add helper function to cast component back to CODEC Lars-Peter Clausen
2014-03-19 13:08 ` Mark Brown
2014-03-18 8:02 ` [PATCH 08/13] ASoC: Track which components have been registered with snd_soc_register_component() Lars-Peter Clausen
2014-03-24 11:18 ` Charles Keepax
2014-03-24 11:33 ` Mark Brown [this message]
2014-03-24 11:40 ` Lars-Peter Clausen
2014-03-24 11:48 ` Mark Brown
2014-03-24 12:07 ` Lars-Peter Clausen
2014-03-24 12:26 ` Mark Brown
2014-03-18 8:02 ` [PATCH 09/13] ASoC: Let snd_soc_platform subclass snd_soc_component Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 10/13] ASoC: Move IO abstraction to the component level Lars-Peter Clausen
2014-04-02 18:23 ` Mark Brown
2014-03-18 8:02 ` [PATCH 11/13] ASoC: Move standard kcontrol helpers " Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 12/13] ASoC: Remove snd_soc_update_bits_locked() Lars-Peter Clausen
2014-03-18 8:02 ` [PATCH 13/13] ASoC: dapm: Rename soc_widget_update_bits_locked() to soc_widget_update_bits() Lars-Peter Clausen
2014-03-18 8:06 ` [PATCH 00/13] ASoC: Move IO and kcontrols to the component level Takashi Iwai
2014-03-18 8:25 ` Lars-Peter Clausen
2014-03-18 14:17 ` Brian Austin
2014-03-18 14:20 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324113330.GI2269@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox