From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/3 v2] ASoC: tas5086: add regulator consumer support
Date: Fri, 28 Mar 2014 11:52:43 +0000 [thread overview]
Message-ID: <20140328115243.GE30768@sirena.org.uk> (raw)
In-Reply-To: <53355F99.4010306@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
On Fri, Mar 28, 2014 at 12:40:09PM +0100, Daniel Mack wrote:
> On 03/28/2014 12:35 PM, Mark Brown wrote:
> > It'd be better style to enable the regulators during probe to read the
> > ID register rather than deferring.
> I had it that way, but that meant I had to introduce device-level pm
> functions in parallel to the soc-level ones, in order to really bring
> down the supply in suspend, even in setups where the codec is not
> actually used.
> Nevermind, I can change it back. Will resend the patches for tas5086 and
> ak4104.
The ususal thing is to power on and off during the probe (though this is
mainly for devices which actively manage the regualtor at runtime rather
than just leaving the regulator on while the sound card is active.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-28 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 20:42 [PATCH 1/3 v2] ASoC: ak5386: add regulator consumer support Daniel Mack
2014-03-27 20:42 ` [PATCH 2/3 v2] ASoC: ak4104: " Daniel Mack
2014-03-28 11:23 ` Mark Brown
2014-03-28 11:27 ` Daniel Mack
2014-03-28 11:53 ` Mark Brown
2014-03-27 20:42 ` [PATCH 3/3 v2] ASoC: tas5086: " Daniel Mack
2014-03-28 11:35 ` Mark Brown
2014-03-28 11:40 ` Daniel Mack
2014-03-28 11:52 ` Mark Brown [this message]
2014-03-28 11:21 ` [PATCH 1/3 v2] ASoC: ak5386: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328115243.GE30768@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox