From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3 v2] ASoC: ak4104: add regulator consumer support
Date: Fri, 28 Mar 2014 12:27:14 +0100 [thread overview]
Message-ID: <53355C92.3000105@gmail.com> (raw)
In-Reply-To: <20140328112345.GZ30768@sirena.org.uk>
On 03/28/2014 12:23 PM, Mark Brown wrote:
> On Thu, Mar 27, 2014 at 09:42:15PM +0100, Daniel Mack wrote:
>> The AK4104 has only one power supply, called VDD. Enable it as long as
>> the codec is in use.
>
> This should update the DT binding too. Also it seems we still have a
> machine driver for Raumfeld using this which doesn't set full
> constraints and isn't being updated here so would be broken as far as I
> can tell.
Yeah, I noticed this one is unfortunately broken since a while already
due to other changes in ASoC. I'm working on fixing this in parallel,
but it's legacy hardware which get less attention than it should. I'll
fix up the constraints along with that.
Want me to resend with a DT bindings fix, or can we do that in 2nd step?
Daniel
next prev parent reply other threads:[~2014-03-28 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 20:42 [PATCH 1/3 v2] ASoC: ak5386: add regulator consumer support Daniel Mack
2014-03-27 20:42 ` [PATCH 2/3 v2] ASoC: ak4104: " Daniel Mack
2014-03-28 11:23 ` Mark Brown
2014-03-28 11:27 ` Daniel Mack [this message]
2014-03-28 11:53 ` Mark Brown
2014-03-27 20:42 ` [PATCH 3/3 v2] ASoC: tas5086: " Daniel Mack
2014-03-28 11:35 ` Mark Brown
2014-03-28 11:40 ` Daniel Mack
2014-03-28 11:52 ` Mark Brown
2014-03-28 11:21 ` [PATCH 1/3 v2] ASoC: ak5386: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53355C92.3000105@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox