Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Vinod Koul <vinod.koul@intel.com>,
	liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
	patches.audio@intel.com
Subject: Re: [PATCH 3/3] ALSA: hda: register selectively for SPT-LP
Date: Thu, 30 Apr 2015 22:23:30 +0100	[thread overview]
Message-ID: <20150430212330.GQ22845@sirena.org.uk> (raw)
In-Reply-To: <s5hk2wtjpsl.wl-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]

On Thu, Apr 30, 2015 at 10:59:22PM +0200, Takashi Iwai wrote:

> Ideally, it'd be best if the system can do everything automatically,
> e.g. loads the DSP driver at first, then falls back to the legacy
> driver if no DSP is found.  But there seems no clean way to do this,
> so far.  Thus the flag was introduced.

Eeew, that's horrible.  I guess another DMI quirk table is going to be
needed...  

> Another way to skip the unwanted driver is just to return -ENODEV from
> its probe callback when the given PCI is SKL and the flag is set.
> Then the driver core ignores this and continues to the next possible
> driver (i.e. the dsp one).  The same should be applied to hda-soc-skl
> driver in vice versa.

Right, that was one of my suggestions.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2015-04-30 21:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 14:52 [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag Vinod Koul
2015-04-30 14:52 ` [PATCH 2/3] ALSA: hda: remove module_pci_driver Vinod Koul
2015-04-30 14:52 ` [PATCH 3/3] ALSA: hda: register selectively for SPT-LP Vinod Koul
2015-04-30 20:33   ` Mark Brown
2015-04-30 20:59     ` Takashi Iwai
2015-04-30 21:23       ` Mark Brown [this message]
2015-05-01  4:31         ` Vinod Koul
2015-04-30 16:02 ` [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag Pierre-Louis Bossart
2015-04-30 19:27   ` Mark Brown
2015-04-30 20:44     ` Takashi Iwai
2015-05-01  4:39       ` Vinod Koul
2015-05-01 14:15         ` Pierre-Louis Bossart
2015-05-01 14:41           ` Mark Brown
2015-05-01 11:13       ` Mark Brown
2015-04-30 20:47 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430212330.GQ22845@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox