Re: [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1522 bytes --]

On Thu, Apr 30, 2015 at 10:44:21PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Thu, Apr 30, 2015 at 11:02:19AM -0500, Pierre-Louis Bossart wrote:
j
> > > This choice is contingent on the BIOS options, you can't enable the DSP if
> > > the BIOS said no DSP...

> > Presumably this flag should be coming from the BIOS by default and this
> > providing a disable only setting for test/development?

> It's hard to know exactly how many models will be with DSP and how
> many without...  The problem we're dealing with is that we'll have two
> individual drivers supporting the very same PCI ID.  And, there is no
> good mechanism to prioritize the driver load on Linux, so far.

Well, I'm a bit confused why we're loading separate drivers at all here.
Shouldn't we be loading one driver and then figuring out what to do with
the hardware based on something like DMI matching (you'd hope that there
would be some config readback from the firmware but recent performance
suggests not)?

> So, this is the consequence after lengthy discussions: it's fairly
> simple but effective enough.  Distros may build both drivers, but
> which driver to use can be decided by this option.  The default value
> of this switch should be set via a Kconfig, but it can be overridden
> dynamically via either a static module option or boot option.

I don't understand how it's going to work well for users, especially
distros where you're building something to be installed on a wide range
of hardware, and it doesn't seem idiomatic.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]