From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, liam.r.girdwood@linux.intel.com,
patches.audio@intel.com
Subject: Re: [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag
Date: Fri, 1 May 2015 15:41:21 +0100 [thread overview]
Message-ID: <20150501144121.GB22845@sirena.org.uk> (raw)
In-Reply-To: <55438A6E.1030102@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]
On Fri, May 01, 2015 at 09:15:10AM -0500, Pierre-Louis Bossart wrote:
> Maybe I confused everyone, it's not complicated: there is a register that
> indicates if the DSP is enabled and that can be queried before launching the
> DSP driver. There is no guessing or need for DMI-based quirks, the
> capabilities are exposed and that should be used. You can then add a driver
> parameter to fall back to legacy mode, e.g. for testing, but that would be a
> second level disable. For once the hardware does tell us what to do, we need
> to use the information...
Oh, OK. That sounds sensible! If that's the case then surely we should
just have one driver for the PCI ID which just skips enabling the DSP
bits based on a combination of the register and the driver parameter?
We shouldn't need this multiple drivers for the same PCI ID stuff.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-01 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:52 [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag Vinod Koul
2015-04-30 14:52 ` [PATCH 2/3] ALSA: hda: remove module_pci_driver Vinod Koul
2015-04-30 14:52 ` [PATCH 3/3] ALSA: hda: register selectively for SPT-LP Vinod Koul
2015-04-30 20:33 ` Mark Brown
2015-04-30 20:59 ` Takashi Iwai
2015-04-30 21:23 ` Mark Brown
2015-05-01 4:31 ` Vinod Koul
2015-04-30 16:02 ` [PATCH 1/3] ALSA: hda: add hdac_adsp_enable module flag Pierre-Louis Bossart
2015-04-30 19:27 ` Mark Brown
2015-04-30 20:44 ` Takashi Iwai
2015-05-01 4:39 ` Vinod Koul
2015-05-01 14:15 ` Pierre-Louis Bossart
2015-05-01 14:41 ` Mark Brown [this message]
2015-05-01 11:13 ` Mark Brown
2015-04-30 20:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501144121.GB22845@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox