Re: ASoC updates for v4.2

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]

On Mon, Jun 22, 2015 at 11:58:24AM +0200, Takashi Iwai wrote:

> In addition to rsnd-card.c, I get a compile warning as below:

> sound/soc/mediatek/mtk-afe-pcm.c:1035:12: warning: 'mtk_afe_runtime_suspend' defined but not used [-Wunused-function]

> And, looking at the code, it seems calling runtime suspend in the
> following way at probe:

>         pm_runtime_enable(&pdev->dev);
>         if (!pm_runtime_enabled(&pdev->dev)) {
>                 ret = mtk_afe_runtime_resume(&pdev->dev);
>                 if (ret)
>                         goto err_pm_disable;
>         }

I'm confused, where's the call to runtime suspend?

> I'm not sure whether this really behaves correctly, especially when a
> kernel is built without CONFIG_PM.

Could you be more specific about the problem you're seeing?  If runtime
PM is disabled pm_runtime_enabled() will return false and we'll run
through the resume path during probe() instead, otherwise we'll runtime
resume whenever we need to use the hardware.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]