From: Mark Brown <broonie@kernel.org>
To: Koro Chen <koro.chen@mediatek.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: ASoC updates for v4.2
Date: Tue, 23 Jun 2015 11:14:51 +0100 [thread overview]
Message-ID: <20150623101451.GY14071@sirena.org.uk> (raw)
In-Reply-To: <1435045502.14283.5.camel@mtksdaap41>
[-- Attachment #1.1: Type: text/plain, Size: 588 bytes --]
On Tue, Jun 23, 2015 at 03:45:02PM +0800, Koro Chen wrote:
> So I think maybe it should be modified like this?
> static int mtk_afe_pcm_dev_remove(struct platform_device *pdev)
> {
> pm_runtime_disable(&pdev->dev);
> + if (!pm_runtime_status_suspended(&pdev->dev))
> + mtk_afe_runtime_suspend(&pdev->dev);
> snd_soc_unregister_component(&pdev->dev);
> snd_soc_unregister_platform(&pdev->dev);
> return 0;
Yes.
> It can fix both build warning and unbalanced calls of suspend/resume.
> Should I send a patch for this?
Yes, please.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-06-23 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 9:26 ASoC updates for v4.2 Mark Brown
2015-06-22 9:58 ` Takashi Iwai
2015-06-22 10:30 ` Mark Brown
2015-06-22 11:24 ` Takashi Iwai
2015-06-22 13:57 ` Mark Brown
2015-06-22 14:10 ` Takashi Iwai
2015-06-22 14:40 ` Takashi Iwai
2015-06-22 14:43 ` Mark Brown
2015-06-22 14:55 ` Takashi Iwai
2015-06-23 7:45 ` Koro Chen
2015-06-23 10:14 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623101451.GY14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=koro.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox