Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Koro Chen <koro.chen@mediatek.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: ASoC updates for v4.2
Date: Mon, 22 Jun 2015 11:58:24 +0200	[thread overview]
Message-ID: <s5hmvzs6p4v.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150622092616.GN14071@sirena.org.uk>

At Mon, 22 Jun 2015 10:26:16 +0100,
Mark Brown wrote:
> 
> The following changes since commit 0f57d86787d8b1076ea8f9cbdddda2a46d534a27:
> 
>   Linux 4.1-rc8 (2015-06-14 15:51:10 -1000)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v4.2-2
> 
> for you to fetch changes up to c99d49a8f81fb35e67b0ffa45f320a75e0b5639d:
> 
>   Merge remote-tracking branch 'asoc/topic/wm8995' into asoc-next (2015-06-22 10:24:37 +0100)
> 
> ----------------------------------------------------------------
> ASoC: Further updates for v4.2
> 
> There's a bunch of additional updates and fixes that came in since my
> orignal pull request here, including DT support for rt5645 and fairly
> large serieses of cleanups and improvements to tas2552 and rcar.

In addition to rsnd-card.c, I get a compile warning as below:

sound/soc/mediatek/mtk-afe-pcm.c:1035:12: warning: 'mtk_afe_runtime_suspend' defined but not used [-Wunused-function]

And, looking at the code, it seems calling runtime suspend in the
following way at probe:

        pm_runtime_enable(&pdev->dev);
        if (!pm_runtime_enabled(&pdev->dev)) {
                ret = mtk_afe_runtime_resume(&pdev->dev);
                if (ret)
                        goto err_pm_disable;
        }

I'm not sure whether this really behaves correctly, especially when a
kernel is built without CONFIG_PM.


Takashi

  reply	other threads:[~2015-06-22  9:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22  9:26 ASoC updates for v4.2 Mark Brown
2015-06-22  9:58 ` Takashi Iwai [this message]
2015-06-22 10:30   ` Mark Brown
2015-06-22 11:24     ` Takashi Iwai
2015-06-22 13:57       ` Mark Brown
2015-06-22 14:10         ` Takashi Iwai
2015-06-22 14:40           ` Takashi Iwai
2015-06-22 14:43           ` Mark Brown
2015-06-22 14:55             ` Takashi Iwai
2015-06-23  7:45           ` Koro Chen
2015-06-23 10:14             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmvzs6p4v.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=koro.chen@mediatek.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox