From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, kbuild test robot <lkp@intel.com>,
Takashi Iwai <tiwai@suse.de>,
Clemens Ladisch <clemens@ladisch.de>,
kbuild-all@01.org, ffado-devel@lists.sf.net
Subject: Re: [PATCH 1/7] ALSA: firewire-tascam: add skeleton for TASCAM FireWire series
Date: Sat, 3 Oct 2015 12:54:02 +0200 [thread overview]
Message-ID: <20151003125402.7581963b@kant> (raw)
In-Reply-To: <560FA68E.8050501@sakamocchi.jp>
On Oct 03 Takashi Sakamoto wrote:
> On 2015年10月03日 18:14, Clemens Ladisch wrote:
> > Most data in the actual configuration ROM is organized as big-endian 32-
> > bit values, so the FireWire core converts _all_ words from big endian to
> > CPU endian. The words that are not actually 32-bit values but strings
> > have to be converted back; the correct function for this is cpu_to_be32().
>
> Yes. And I forgot a pair of cpu_to_be32/be32_to_cpu is symmetric each other!
> (I'm really a stupid guy, sigh...)
Nah, it's easy to miss that struct fw_device.config_rom ist not identical
with the on-the-wire format (on little endian hosts, that is). This has
irritated others before. I think this CPU-endian ROM buffer caters to
simpler ROM parsing code in the overall picture. Text leaf parsing seems
to be the only exception where a big-endian buffer would be preferable,
but before your TASCAM driver all of the text leaf parsing was
concentrated in core-device.c::textual_leaf_to_string().
--
Stefan Richter
-=====-===== =-=- ---==
http://arcgraph.de/sr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2015-10-03 10:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 13:02 [PATCH 0/7 v3] firewire-tascam: new driver for TASCAM FireWire series Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 1/7] ALSA: firewire-tascam: add skeleton " Takashi Sakamoto
2015-10-01 13:54 ` kbuild test robot
2015-10-02 16:24 ` Takashi Iwai
2015-10-02 18:47 ` Clemens Ladisch
2015-10-03 2:34 ` Takashi Sakamoto
2015-10-03 8:51 ` Takashi Iwai
2015-10-03 10:33 ` Stefan Richter
2015-10-03 9:14 ` Clemens Ladisch
2015-10-03 9:57 ` Takashi Sakamoto
2015-10-03 10:54 ` Stefan Richter [this message]
2015-10-04 11:54 ` Takashi Sakamoto
2015-10-03 16:07 ` Takashi Iwai
2015-10-03 23:33 ` Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 2/7] ALSA: firewire-tascam: add a structure for model-dependent parameters Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 3/7] ALSA: firewire-tascam: add proc node to show firmware information Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 4/7] ALSA: firewire-tascam: add data block processing layer Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 5/7] ALSA: firewire-tascam: add streaming functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 6/7] ALSA: firewire-tascam: add PCM functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 7/7] ALSA: firewire-tascam: add hwdep interface Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003125402.7581963b@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=ffado-devel@lists.sf.net \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox