From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>, Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
kbuild test robot <lkp@intel.com>,
ffado-devel@lists.sf.net, kbuild-all@01.org
Subject: Re: [PATCH 1/7] ALSA: firewire-tascam: add skeleton for TASCAM FireWire series
Date: Fri, 2 Oct 2015 20:47:38 +0200 [thread overview]
Message-ID: <560ED14A.2060404@ladisch.de> (raw)
In-Reply-To: <s5hd1wxdyr7.wl-tiwai@suse.de>
Takashi Iwai wrote:
> kbuild test robot wrote:
>>>> sound/firewire/tascam/tascam.c:23:16: sparse: cast to restricted __be32
>>
>> > 23 data = be32_to_cpu(fw_dev->config_rom[28]);
>
> The code itself looks correct. data is CPU endian.
> The problem looks rather like that fw_dev->config_rom[] is u32.
>
> Stefan, can it be changed to __be32 instead?
config_rom[] is CPU endian, too.
Strings should be read with fw_csr_string().
Regards,
Clemens
next prev parent reply other threads:[~2015-10-02 18:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 13:02 [PATCH 0/7 v3] firewire-tascam: new driver for TASCAM FireWire series Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 1/7] ALSA: firewire-tascam: add skeleton " Takashi Sakamoto
2015-10-01 13:54 ` kbuild test robot
2015-10-02 16:24 ` Takashi Iwai
2015-10-02 18:47 ` Clemens Ladisch [this message]
2015-10-03 2:34 ` Takashi Sakamoto
2015-10-03 8:51 ` Takashi Iwai
2015-10-03 10:33 ` Stefan Richter
2015-10-03 9:14 ` Clemens Ladisch
2015-10-03 9:57 ` Takashi Sakamoto
2015-10-03 10:54 ` Stefan Richter
2015-10-04 11:54 ` Takashi Sakamoto
2015-10-03 16:07 ` Takashi Iwai
2015-10-03 23:33 ` Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 2/7] ALSA: firewire-tascam: add a structure for model-dependent parameters Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 3/7] ALSA: firewire-tascam: add proc node to show firmware information Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 4/7] ALSA: firewire-tascam: add data block processing layer Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 5/7] ALSA: firewire-tascam: add streaming functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 6/7] ALSA: firewire-tascam: add PCM functionality Takashi Sakamoto
2015-10-01 13:02 ` [PATCH 7/7] ALSA: firewire-tascam: add hwdep interface Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560ED14A.2060404@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sf.net \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
--cc=o-takashi@sakamocchi.jp \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox