From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Pan Xiuli <xiuli.pan@linux.intel.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
Mark Brown <broonie@kernel.org>, Alan Cox <alan@linux.intel.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support
Date: Thu, 21 Feb 2019 14:29:57 +0200 [thread overview]
Message-ID: <20190221122957.GF9224@smile.fi.intel.com> (raw)
In-Reply-To: <485cf6b0-e685-a376-711c-a3cd5c04833a@linux.intel.com>
On Wed, Feb 20, 2019 at 02:18:01PM -0600, Pierre-Louis Bossart wrote:
> On 2/20/19 11:44 AM, Mark Brown wrote:
> > On Wed, Feb 13, 2019 at 04:07:27PM -0600, Pierre-Louis Bossart wrote:
> > > + /* make sure count is <= avail */
> > > + count = avail > count ? count : avail;
> > count = min(avail, count)?
> as discussed in the last review, we didn't use min() since it adds a number
> of obscure warnings with sparse. I haven't found any time to look into this
> so for now left the code as is. Sparse is a useful tool for the address
> checks (topology/DMAs with _le32, __iomem, etc), the fewer warnings we get
> the better.
Shouldn't be sparse itself get fixed?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-02-21 12:29 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 22:07 [PATCH v4 00/14] ASoC: Sound Open Firmware (SOF) core Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 01/14] ASoC: SOF: Add Sound Open Firmware driver core Pierre-Louis Bossart
2019-02-14 9:25 ` Takashi Iwai
2019-02-14 14:53 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-19 15:38 ` Mark Brown
2019-02-20 14:35 ` Pierre-Louis Bossart
2019-02-20 16:26 ` Mark Brown
2019-02-20 21:32 ` Pierre-Louis Bossart
2019-02-21 18:47 ` Mark Brown
2019-02-22 0:08 ` Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 02/14] ASoC: SOF: Add Sound Open Firmware KControl support Pierre-Louis Bossart
2019-02-14 9:30 ` Takashi Iwai
2019-02-14 14:35 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 15:21 ` Takashi Iwai
2019-02-13 22:07 ` [PATCH v4 03/14] ASoC: SOF: Add driver debug support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 04/14] ASoC: SOF: Add support for IPC IO between DSP and Host Pierre-Louis Bossart
2019-02-14 11:52 ` Takashi Iwai
2019-02-14 14:56 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-20 17:31 ` Mark Brown
2019-02-13 22:07 ` [PATCH v4 05/14] ASoC: SOF: Add PCM operations support Pierre-Louis Bossart
2019-02-14 11:20 ` Takashi Iwai
2019-02-14 15:07 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 20:42 ` Pierre-Louis Bossart
2019-02-18 15:51 ` Daniel Baluta
2019-02-13 22:07 ` [PATCH v4 06/14] ASoC: SOF: Add support for loading topologies Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support Pierre-Louis Bossart
2019-02-14 13:19 ` Takashi Iwai
2019-02-14 15:13 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-20 17:44 ` Mark Brown
2019-02-20 20:18 ` Pierre-Louis Bossart
2019-02-21 12:29 ` Andy Shevchenko [this message]
2019-02-21 14:57 ` Pierre-Louis Bossart
2019-02-21 15:04 ` Mark Brown
2019-02-13 22:07 ` [PATCH v4 08/14] ASoC: SOF: Add DSP HW abstraction operations Pierre-Louis Bossart
2019-02-14 13:21 ` Takashi Iwai
2019-02-14 15:22 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 13:45 ` Andy Shevchenko
2019-02-14 15:21 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 09/14] ASoC: SOF: Add firmware loader support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 10/14] ASoC: SOF: Add userspace ABI support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 11/14] ASoC: SOF: Add PM support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 12/14] ASoC: SOF: Add Nocodec machine driver support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 13/14] ASoC: SOF: Add xtensa support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 14/14] ASoC: SOF: Add utils Pierre-Louis Bossart
2019-02-14 13:33 ` Takashi Iwai
2019-02-14 13:37 ` Takashi Iwai
2019-02-18 20:03 ` [v4,00/14] ASoC: Sound Open Firmware (SOF) core Xiang Xiao
2019-02-19 9:49 ` Srinivas Kandagatla
2019-02-19 15:09 ` xiang xiao
2019-02-19 15:55 ` Pierre-Louis Bossart
2019-02-21 4:39 ` Vinod Koul
2019-02-21 10:42 ` Arnaud Pouliquen
2019-02-21 11:28 ` Mark Brown
2019-02-21 23:49 ` Pierre-Louis Bossart
2019-02-21 15:27 ` Pierre-Louis Bossart
2019-02-22 8:32 ` xiang xiao
2019-02-22 11:15 ` Keyon Jie
2019-02-22 18:21 ` xiang xiao
2019-02-25 3:05 ` [Sound-open-firmware] [v4, 00/14] " Keyon Jie
2019-02-22 14:48 ` Pierre-Louis Bossart
2019-02-22 18:41 ` xiang xiao
2019-02-22 21:52 ` Pierre-Louis Bossart
2019-02-23 16:42 ` xiang xiao
2019-02-25 10:16 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221122957.GF9224@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox