From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver
Date: Fri, 24 Apr 2020 10:44:27 -0500 [thread overview]
Message-ID: <28900433-f2a7-bf4e-7861-5522f0aedee1@linux.intel.com> (raw)
In-Reply-To: <s5hk125rr82.wl-tiwai@suse.de>
>> Hmm, I wonder is this now doing more harm than good. Based on browsing
>> through the related code in hda-codec.c and friends, it would seem
>> "sofbus" as the default is mostly harmless, but I could have missed
>> something.
>
> That's currently harmless since no codec driver defines "sofbus"
> model, hence the HDA parser continues to match with the default
> quirks. OTOH, the fixed "sofbus" model is fairly useless. So, feel
> free to take my ack, too:
For my education, are you saying that the default should be that the
modelname is NULL, and the hda auto parser will use known quirks based
on PCI/SSID information, and when the user sets the model name to a
non-NULL string it will force a specific quirk to be used?
Thanks!
next prev parent reply other threads:[~2020-04-24 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:25 [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver Jaroslav Kysela
2020-04-24 12:24 ` Kai Vehmanen
2020-04-24 12:41 ` Takashi Iwai
2020-04-24 15:44 ` Pierre-Louis Bossart [this message]
2020-04-24 16:06 ` Takashi Iwai
2020-04-24 17:01 ` Pierre-Louis Bossart
2020-04-24 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28900433-f2a7-bf4e-7861-5522f0aedee1@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox