Re: [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver

[Takashi Iwai <tiwai@suse.de>]

On Fri, 24 Apr 2020 14:24:30 +0200,
Kai Vehmanen wrote:
> 
> Hey,
> 
> On Fri, 24 Apr 2020, Jaroslav Kysela wrote:
> 
> > It may be useful to pass the specific model to the generic HDA codec
> > routines like the legacy HDA driver (snd-hda-intel) allows.
> [...]
> > Original proposal: https://lore.kernel.org/alsa-devel/20191203161908.7496-1-perex@perex.cz/
> 
> not sure why this got stuck last year, but seems like a welcome
> addition:
> 
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> 
> > The model name "sofbus" is tricky anyway.
> 
> Hmm, I wonder is this now doing more harm than good. Based on browsing 
> through the related code in hda-codec.c and friends, it would seem 
> "sofbus" as the default is mostly harmless, but I could have missed
> something.

That's currently harmless since no codec driver defines "sofbus"
model, hence the HDA parser continues to match with the default
quirks. OTOH, the fixed "sofbus" model is fairly useless.  So, feel
free to take my ack, too:

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi