Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Keyon Jie <yang.jie@linux.intel.com>, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com,
	ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH v2 0/2] ASoC topology header parsing refinement
Date: Tue, 26 May 2020 14:40:20 +0200	[thread overview]
Message-ID: <32df1cf8-8a57-7fc8-c694-6ddcc03fffca@intel.com> (raw)
In-Reply-To: <20200521074847.71406-1-yang.jie@linux.intel.com>

On 2020-05-21 9:48 AM, Keyon Jie wrote:
> This small series is to optimize the header logging during the topology
> parsing. This is verified work fine on both SOF and SST drivers
> (bxt_rt298 with dfw_sst.bin).
> 
> Change History:
> v2:
> - Change the internal used array to be 'static' to fix the issue
>    reported by: kbuild test robot <lkp@intel.com>
> - Add testing coverage including Intel SST driver also.
> 
> v1:
> - Initial version.
> 
> Keyon Jie (2):
>    ASoC: topology: refine and log the header in the correct pass
>    ASoC: topology: remove the redundant pass checks
> 
>   sound/soc/soc-topology.c | 99 ++++++++++++++++++----------------------
>   1 file changed, 44 insertions(+), 55 deletions(-)
> 

No regression after applying these and running through SST CI on cAVS 
1.5+ (GLK) and 1.8 (CNL).

Given some comments on 1/2 though, believe it could be simplified.

Czarek

  parent reply	other threads:[~2020-05-26 12:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21  7:48 [PATCH v2 0/2] ASoC topology header parsing refinement Keyon Jie
2020-05-21  7:48 ` [PATCH v2 1/2] ASoC: topology: refine and log the header in the correct pass Keyon Jie
2020-05-26 12:38   ` Cezary Rojewski
2020-05-26 14:45     ` Keyon Jie
2020-05-26 15:30       ` Cezary Rojewski
2020-05-27  1:17         ` Keyon Jie
2020-05-21  7:48 ` [PATCH v2 2/2] ASoC: topology: remove the redundant pass checks Keyon Jie
2020-05-26 12:40 ` Cezary Rojewski [this message]
2020-05-26 13:29   ` [PATCH v2 0/2] ASoC topology header parsing refinement Pierre-Louis Bossart
2020-05-27  1:05     ` Keyon Jie
2020-05-26 14:34   ` Keyon Jie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32df1cf8-8a57-7fc8-c694-6ddcc03fffca@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox