Re: [PATCH v2 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2020-04-22 14:05, Mateusz Gorski wrote:
> For pipes supporting multiple input/output formats, kcontrol is
> created and selection of pipe input and output configuration
> is done based on control set.
> 
> If more than one configuration is supported, then this patch
> allows user to select configuration of choice
> using amixer settings.
> 

> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index 58f77b6c5cda..2e6eca619c4e 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -579,6 +579,38 @@ static int skl_tplg_unload_pipe_modules(struct skl_dev *skl,
>   	return ret;
>   }
>   
> +static bool skl_tplg_is_multi_fmt(struct skl_dev *skl, struct skl_pipe *pipe)
> +{
> +	int i;
> +	struct skl_pipe_fmt *cur_fmt;
> +	struct skl_pipe_fmt *next_fmt;
> +

Hmm, some code-cosmetics are left unattended too.
Please reorder 'i' declaration to the bottom.