From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mateusz Gorski <mateusz.gorski@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
tiwai@suse.com
Subject: Re: [PATCH v2 0/3] Add support for different DMIC configurations
Date: Thu, 23 Apr 2020 11:11:05 +0200 [thread overview]
Message-ID: <89873366-c063-5754-0e18-511477c3daa5@intel.com> (raw)
In-Reply-To: <20200422120532.31492-1-mateusz.gorski@linux.intel.com>
On 2020-04-22 14:05, Mateusz Gorski wrote:
> Set of patches to enable DMIC capture on different hardware
> configurations.
> Information about supported DMIC configuration is read from NHLT and
> correct pipeline configuration is selected automatically.
> Also, adding additional option for topology binary name which is
> based on used machine driver.
*seems like this thread is missing few maintainers in CC*
>
> Mateusz Gorski (3):
> ASoC: Intel: Skylake: Add alternative topology binary name
> ASoC: Intel: Multiple I/O PCM format support for pipe
> ASoC: Intel: Skylake: Automatic DMIC format configuration according to
> information from NHLT
>
> Changes in v2:
> - removed patch 1/4 swapping machine device and platform device
> registration order
> - alt_tplg_name creation now uses different field to read machine driver
> name
> - including of <sound/soc-acpi.h> moved to different patch
Ain't change-block supposed to be just below message body?
>
> include/uapi/sound/skl-tplg-interface.h | 2 +
> sound/soc/intel/skylake/skl-topology.c | 189 +++++++++++++++++++++++-
> sound/soc/intel/skylake/skl-topology.h | 1 +
> 3 files changed, 187 insertions(+), 5 deletions(-)
>
You have forgotten to add my Reviewed-by tag as both, v1 and v2 were
reviewed by me internally before upstreaming.
Thanks for addressing Pierre's review - indeed i2s_dev field usage could
have been avoided. Good review, Pierre.
Don't believe series need to be resend just to fix cosmetics:
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2020-04-23 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:05 [PATCH v2 0/3] Add support for different DMIC configurations Mateusz Gorski
2020-04-22 12:05 ` [PATCH v2 1/3] ASoC: Intel: Skylake: Add alternative topology binary name Mateusz Gorski
2020-04-23 10:48 ` Cezary Rojewski
2020-04-22 12:05 ` [PATCH v2 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe Mateusz Gorski
2020-04-23 10:46 ` Cezary Rojewski
2020-04-22 12:05 ` [PATCH v2 3/3] ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Mateusz Gorski
2020-04-23 9:11 ` Cezary Rojewski [this message]
2020-04-23 10:21 ` [PATCH v2 0/3] Add support for different DMIC configurations Mark Brown
2020-04-23 10:42 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89873366-c063-5754-0e18-511477c3daa5@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=mateusz.gorski@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox