From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mateusz Gorski <mateusz.gorski@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.com
Subject: Re: [PATCH v2 1/3] ASoC: Intel: Skylake: Add alternative topology binary name
Date: Thu, 23 Apr 2020 12:48:02 +0200 [thread overview]
Message-ID: <554b3330-b3c8-4c73-3755-d780f930b843@intel.com> (raw)
In-Reply-To: <20200422120532.31492-2-mateusz.gorski@linux.intel.com>
On 2020-04-22 14:05, Mateusz Gorski wrote:
> Add alternative topology binary file name based on used machine driver
> and fallback to use this name after failed attempt to load topology file
> with name based on NHLT.
> This change addresses multiple issues with current mechanism, for
> example - there are devices without NHLT table, and that currently
> results in tplg_name being empty.
>
> Signed-off-by: Mateusz Gorski <mateusz.gorski@linux.intel.com>
> ---
>
> Changes in v2:
> - added <sound/soc-acpi.h> include
> - machine driver name is now read from different field
>
> @@ -3575,6 +3588,9 @@ int skl_tplg_init(struct snd_soc_component *component, struct hdac_bus *bus)
> }
> }
>
> +component_load:
> +
> +
> /*
> * The complete tplg for SKL is loaded as index 0, we don't use
> * any other index
>
Looks like double newline after 'component_load' slipped through my
eyes. Please fix it.
next prev parent reply other threads:[~2020-04-23 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:05 [PATCH v2 0/3] Add support for different DMIC configurations Mateusz Gorski
2020-04-22 12:05 ` [PATCH v2 1/3] ASoC: Intel: Skylake: Add alternative topology binary name Mateusz Gorski
2020-04-23 10:48 ` Cezary Rojewski [this message]
2020-04-22 12:05 ` [PATCH v2 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe Mateusz Gorski
2020-04-23 10:46 ` Cezary Rojewski
2020-04-22 12:05 ` [PATCH v2 3/3] ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Mateusz Gorski
2020-04-23 9:11 ` [PATCH v2 0/3] Add support for different DMIC configurations Cezary Rojewski
2020-04-23 10:21 ` Mark Brown
2020-04-23 10:42 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554b3330-b3c8-4c73-3755-d780f930b843@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=mateusz.gorski@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox