Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx broken on Alpha
@ 2008-04-01 20:26 Bob Tracy
  2008-04-01 21:02 ` Michael Cree
  0 siblings, 1 reply; 54+ messages in thread
From: Bob Tracy @ 2008-04-01 20:26 UTC (permalink / raw)
  To: Tyson Whitehead
  Cc: Bob Tracy, Rene Herman, Michael Cree, Takashi Iwai, ALSA devel,
	linux-kernel, Ivan Kokshaysky, linux-alpha, Krzysztof Helt

Tyson Whitehead wrote:
> Okay.  I finally got everything tested on my Miata.  Unless I missed 
> something, the es1888_init routine only gets compiled in with 
> CONFIG_ALPHA_MIATA.

The current arch/alpha/kernel/Makefile build logic shows es1888.o built
as part of CONFIG_ALPHA_GENERIC, but if that option isn't enabled, then
enabling any of the following configuration options will cause es1888.o
to be built:

CONFIG_ALPHA_DP264
CONFIG_ALPHA_SHARK
CONFIG_ALPHA_MIATA

> As I've been using the debian generic kernel (i.e., 
> CONFIG_ALPHA_GENERIC), I have never relied on this routine for anything.
> 
> I did discover, however, when I compiled my own kernel (2.6.25-rc5) with 
> CONFIG_ALPHA_MIATA, things stopped working.  Specifically, I no longer 
> got any interupts (with or without the es1888_init patch and with or 
> without the alternative es188xx interupt patch) associated with either 
> the builtin sound card (es1888) or the IDE controller (CMD646).

Interesting.  I *seldom* use the Debian generic kernel.  It's available,
and I install updated versions when they are released, but all of my
testing has been with kernels built from the standard kernel.org sources
with CONFIG_ALPHA_MIATA enabled.

> With CONFIG_ALPHA_GENERIC I only get one interupt with the es18xx driver 
> unless I applied to "alternative interupt" handling code.  Further, 
> sometime between 2.6.14 and 2.6.16, mpg321 (using the alsa driver) 
> started generating "Bad page state in process 'mpg321' ... Trying to fix 
> it up, but a reboot is needed" kernel messages.

This is consistent with what I remember you reporting when we were
looking at this back in the 2.6.14 timeframe.  I was reporting the "bad
page state" problems with 2.6.22-rc6 and -rc7.  In my case, the trigger
was a different application, but only happened when snd_es18xx was
loaded.  Hugh Dickins suggested it was a regression introduced in
2.6.15 that I had managed to successfully avoid tripping on :-).  The
analysis went something like this:

sound/isa/es18xx.c:
	snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, ...
led us to sound/core/memalloc.c:
	res = dma_alloc_coherent(dev, PAGE_SIZE << pg, dma, gfp_flags);
where __GFP_COMP was carefully included in gfp_flags to avoid the
kinds of problems I was seeing (replacing the pre-2.6.15 use of
PageReserved).

Hugh said we could blame him or Nick for removing the special
PageReserved usage, or the Alpha for ignoring gfp_flags in the
following:

  #define dma_alloc_coherent(dev, size, addr, gfp)      \
                pci_alloc_consistent(alpha_gendev_to_pci(dev), size, addr)

The workaround (until the official patch was issued) was a small patch
against arch/alpha/kernel/pci_iommu.c:pci_alloc_consistent() that
replaced "gfp_t gfp = GFP_ATOMIC;" with "gfp_t gfp = GFP_ATOMIC|__GFP_COMP;".
That eliminated the "bad page state" errors for me, and I don't recall
what the official patch was.

-- 
------------------------------------------------------------------------
Bob Tracy          |  "I was a beta tester for dirt.  They never did
rct@frus.com       |   get all the bugs out." - Steve McGrew on /.
------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 54+ messages in thread
* Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx broken on Alpha
@ 2008-04-01 19:07 Rene Herman
  2008-04-01 20:32 ` Bob Tracy
  0 siblings, 1 reply; 54+ messages in thread
From: Rene Herman @ 2008-04-01 19:07 UTC (permalink / raw)
  To: Tyson Whitehead
  Cc: Bob Tracy, Michael Cree, Takashi Iwai, ALSA devel, linux-kernel,
	Ivan Kokshaysky, linux-alpha, Krzysztof Helt

On 01-04-08 20:34, Rene Herman wrote:

> On 01-04-08 20:07, Tyson Whitehead wrote:
> 
>> Hope this helps.
> 
> Not really no.

Sorry for the multiple copies; my ISP is crashing again.

Rene.

^ permalink raw reply	[flat|nested] 54+ messages in thread
* Re: [regression] 2.6.25-rc4 snd-es18xx broken on Alpha
@ 2008-03-14 23:33 Bob Tracy
  0 siblings, 0 replies; 54+ messages in thread
From: Bob Tracy @ 2008-03-14 23:33 UTC (permalink / raw)
  To: twhitehe
  Cc: ALSA devel, Michael Cree, Krzysztof Helt, Takashi Iwai,
	Rene Herman, linux-kernel, Ivan Kokshaysky, linux-alpha,
	Bob Tracy

rct wrote:
> Rene Herman wrote:
> > Okay, and applying the attached just makes your sound completely dead in the 
> > water?
> > (patch to remove es1888_init from a Miata build omitted)
> 
> I'll try a build with the old OSS "sb" driver, and if that works ok, we
> may be able to do away with es1888_init() on the Miata.  Tyson -- I
> think you have a Miata if I'm remembering correctly: can you confirm
> these observations?

Quick followup: OSS "sb" driver works fine without es1888_init().

-- 
------------------------------------------------------------------------
Bob Tracy          |  "I was a beta tester for dirt.  They never did
rct@frus.com       |   get all the bugs out." - Steve McGrew on /.
------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 54+ messages in thread
[parent not found: <20080308035828.E9403DBA2@gherkin.frus.com>]

end of thread, other threads:[~2008-04-01 21:02 UTC | newest]

Thread overview: 54+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20080309235800.17D26DBA2@gherkin.frus.com>
     [not found] ` <47D4E480.3090309@orcon.net.nz>
2008-03-10 15:17   ` [regression] 2.6.25-rc4 snd-es18xx broken on Alpha Rene Herman
2008-03-10 15:21     ` Rene Herman
2008-03-10 16:21     ` Bob Tracy
2008-03-10 16:56       ` Rene Herman
2008-03-10 17:14         ` Takashi Iwai
2008-03-10 19:29           ` [alsa-devel] " Rene Herman
2008-03-10 22:22             ` Bob Tracy
2008-03-10 22:33               ` Rene Herman
2008-03-11 14:07                 ` [alsa-devel] " Bob Tracy
2008-03-11 15:17                   ` Rene Herman
2008-03-11 18:08                     ` Bob Tracy
2008-03-11 20:00                       ` [alsa-devel] " Michael Cree
2008-03-11 20:34                         ` Bob Tracy
2008-03-12 14:40                         ` Bob Tracy
2008-03-12 19:34                           ` Rene Herman
2008-03-12 20:31                             ` [alsa-devel] " Bob Tracy
2008-03-12 21:12                               ` Rene Herman
2008-03-13  4:24                                 ` Bob Tracy
2008-03-17 22:00                                   ` Rene Herman
2008-03-18  3:24                                     ` [alsa-devel] " Bob Tracy
2008-03-18  3:54                                       ` Michael Cree
2008-03-23 10:40                                         ` Michael Cree
2008-03-24 18:15                                           ` Rene Herman
2008-03-24 23:56                                             ` Michael Cree
2008-03-25  0:29                                               ` [alsa-devel] " Rene Herman
2008-03-25  1:22                                                 ` Michael Cree
2008-03-25  2:22                                                   ` Rene Herman
2008-03-30  5:18                                                     ` Bob Tracy
2008-03-30 10:02                                                       ` Michael Cree
2008-03-30  9:13                                                     ` [alsa-devel] " Michael Cree
2008-03-25  2:46                                                 ` Rene Herman
2008-03-30 21:07                                                 ` Bob Tracy
2008-03-30 21:11                                                   ` Michael Cree
2008-03-30 21:18                                                     ` Bob Tracy
2008-03-30  4:24                                             ` Bob Tracy
2008-03-30 22:09                                     ` [alsa-devel] " Bob Tracy
2008-03-14 13:13                                 ` Bob Tracy
2008-03-15  1:18                                   ` Tyson Whitehead
2008-03-17 22:04                                     ` Rene Herman
2008-03-18 13:55                                       ` Tyson Whitehead
2008-03-18 22:57                                         ` Rene Herman
     [not found]                                     ` <s5hskypnwp8.wl%tiwai@suse.de>
2008-03-18 14:16                                       ` Tyson Whitehead
2008-03-29  6:42                                         ` Bob Tracy
2008-03-29 12:09                                           ` [alsa-devel] " Rene Herman
2008-03-30 16:14                                             ` Ivan Kokshaysky
2008-03-30 21:17                                               ` Michael Cree
2008-03-30 20:24                                             ` [alsa-devel] " Bob Tracy
2008-03-12 22:48                             ` Rafael J. Wysocki
2008-03-23  9:48                         ` Michael Cree
2008-03-11  5:36         ` Bob Tracy
2008-04-01 20:26 [alsa-devel] " Bob Tracy
2008-04-01 21:02 ` Michael Cree
  -- strict thread matches above, loose matches on Subject: below --
2008-04-01 19:07 [alsa-devel] " Rene Herman
2008-04-01 20:32 ` Bob Tracy
2008-03-14 23:33 Bob Tracy
     [not found] <20080308035828.E9403DBA2@gherkin.frus.com>
     [not found] ` <20080309153425.GA1391@jurassic.park.msu.ru>
2008-03-10 15:08   ` Rene Herman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox