From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Daniel Mack <zonque@gmail.com>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, jsarha@ti.com
Subject: Re: [PATCH 0/7] ASoC:davinci-mcasp: bc polarity fix and proper format support
Date: Wed, 9 Apr 2014 15:51:35 +0300 [thread overview]
Message-ID: <53454257.6070000@ti.com> (raw)
In-Reply-To: <53453925.8040202@gmail.com>
Hi Daniel,
On 04/09/2014 03:12 PM, Daniel Mack wrote:
> Hi Peter,
>
> On 04/04/2014 06:38 PM, Peter Ujfalusi wrote:
>> On 04/04/2014 04:24 PM, Daniel Mack wrote:
>
>>> The cleanups look sane, though. I can test them on AM33xx based hardware
>>> early next week. If you don't want to hold them off until then, no
>>> problem. I can also send fixups in case I spot a regression.
>>
>> That would be great if you could also test these. It seams you have quite good
>> array of codecs available.
>
> I tested this series with a CS4271 codec in I2S mode, and things still
> work as expected, except for the fact that the LRCLK is now inverted in
> comparison to the old state.
Yes, this is expected. I think you were asking for NB_IF with the old code,
right? The old code was - wrongly IMHO - configured the I2S mode's FS in
inverted mode: NB_NF would end up to send the left channel when the FS is
high. This is not correct. NB_NF means in I2S is that left channel is when FS
is low, right channel is when FS is high.
Most of the daVinci device used DSP_B, which was correct in terms of FS.
The NB_IF with cs4271 was fine since the codec driver did not checked for
invert it only cares about the protocol. Page 20 of the cs4271 shows the I2S.
With this series we can use the correct DAIFMT_I2S + NB_NF with standard
compliant codecs.
> After some debugging, however, I have confidence that the behaviour with
> the patches applied is in fact correct, we just need to flip the bits in
> our ASoC machine driver, which is no big deal.
>
>
> Thanks for the cleanups again!
Thanks for testing it!
--
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-04-09 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:31 [PATCH 0/7] ASoC:davinci-mcasp: bc polarity fix and proper format support Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 1/7] ASoC: davinci-mcasp: Fix bit clock polarity settings Peter Ujfalusi
2014-04-08 18:04 ` Mark Brown
2014-04-04 11:31 ` [PATCH 2/7] ASoC: davinci-mcasp: Format data delay configuration enhancement Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 3/7] ASoC: davinci-mcasp: Support for DSP_A format Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 4/7] ASoC: davinci-mcasp: Move the FS polarity change out from the switch case Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 5/7] ASoC: davinci-mcasp: Add support for I2S format Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 6/7] ASoC: davinci-mcasp: Support for LEFT_J format Peter Ujfalusi
2014-04-04 11:31 ` [PATCH 7/7] ASoC: davinci-mcasp: Remove excess empty lines from davinci_mcasp_set_dai_fmt() Peter Ujfalusi
2014-04-04 13:24 ` [PATCH 0/7] ASoC:davinci-mcasp: bc polarity fix and proper format support Daniel Mack
2014-04-04 16:38 ` Peter Ujfalusi
2014-04-09 12:12 ` Daniel Mack
2014-04-09 12:51 ` Peter Ujfalusi [this message]
2014-04-14 16:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53454257.6070000@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox