* [PATCH] ASoC: fsl_ssi: No need call of_device_is_available()
@ 2015-05-08 2:24 Fabio Estevam
2015-05-08 3:16 ` Timur Tabi
2015-05-08 11:05 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-05-08 2:24 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel, timur
From: Fabio Estevam <fabio.estevam@freescale.com>
The comment and the call to of_device_is_available() are not really
needed.
It is the expected behaviour to probe only the ssi nodes that are
enabled in the device tree.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/fsl_ssi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 0d48804..c7647e0 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1292,13 +1292,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)
void __iomem *iomem;
char name[64];
- /* SSIs that are not connected on the board should have a
- * status = "disabled"
- * property in their device tree nodes.
- */
- if (!of_device_is_available(np))
- return -ENODEV;
-
of_id = of_match_device(fsl_ssi_ids, &pdev->dev);
if (!of_id || !of_id->data)
return -EINVAL;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: No need call of_device_is_available()
2015-05-08 2:24 [PATCH] ASoC: fsl_ssi: No need call of_device_is_available() Fabio Estevam
@ 2015-05-08 3:16 ` Timur Tabi
2015-05-08 11:05 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2015-05-08 3:16 UTC (permalink / raw)
To: Fabio Estevam, broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
Fabio Estevam wrote:
> The comment and the call to of_device_is_available() are not really
> needed.
>
> It is the expected behaviour to probe only the ssi nodes that are
> enabled in the device tree.
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
Acked-by: Timur Tabi <timur@tabi.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: fsl_ssi: No need call of_device_is_available()
2015-05-08 2:24 [PATCH] ASoC: fsl_ssi: No need call of_device_is_available() Fabio Estevam
2015-05-08 3:16 ` Timur Tabi
@ 2015-05-08 11:05 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-05-08 11:05 UTC (permalink / raw)
To: Fabio Estevam; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel, timur
[-- Attachment #1.1: Type: text/plain, Size: 223 bytes --]
On Thu, May 07, 2015 at 11:24:16PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The comment and the call to of_device_is_available() are not really
> needed.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-08 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-08 2:24 [PATCH] ASoC: fsl_ssi: No need call of_device_is_available() Fabio Estevam
2015-05-08 3:16 ` Timur Tabi
2015-05-08 11:05 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox