From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jenny TC <jenny.tc@intel.corp-partner.google.com>,
alsa-devel@alsa-project.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Ughreja Rakesh A <rakesh.a.ughreja@intel.com>,
Periyasamy SriramX <sriramx.periyasamy@intel.com>,
Kumar Abhijeet <abhijeet.kumar@intel.com>,
Kale Sanyog R <sanyog.r.kale@intel.com>
Cc: N Harshapriya <harshapriya.n@intel.com>,
M Naveen <naveen.m@intel.com>,
M R Sathya Prakash <sathya.prakash.m.r@intel.com>,
Jenny TC <jenny.tc@intel.com>,
Nujella Sathyanarayana <sathyanarayana.nujella@intel.com>
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support
Date: Sat, 23 Mar 2019 09:39:37 -0400 [thread overview]
Message-ID: <570ed8a0-a83a-9da5-082a-2ce68a39d367@linux.intel.com> (raw)
In-Reply-To: <1553346610-1012-1-git-send-email-jenny.tc@intel.corp-partner.google.com>
On 3/23/19 9:10 AM, Jenny TC wrote:
> From: Jenny TC <jenny.tc@intel.com>
>
> To enable S24_LE format, sample_type in topology fw has to be set to 1.
> But sample_type defined in topology firmware configuration is not
> getting reflected in the dsp param. This patch sets sample_type in base
> config so that the sample type defined in the topology firmware is reflected
> in the dsp params. This issues was uncovered while debugging the S24_LE format
> which require the MSB byte in 32 bit word to be skipped. Setting sample_type
> in topology firmware to 1 helps to skip MSB byte word.
>
> Signed-off-by: Jenny TC <jenny.tc@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/skylake/skl-messages.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
> index 28c4806..4bf70b4 100644
> --- a/sound/soc/intel/skylake/skl-messages.c
> +++ b/sound/soc/intel/skylake/skl-messages.c
> @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
> base_cfg->audio_fmt.bit_depth = format->bit_depth;
> base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
> base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
> + base_cfg->audio_fmt.sample_type = format->sample_type;
>
> dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
> format->bit_depth, format->valid_bit_depth,
>
prev parent reply other threads:[~2019-03-23 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 13:10 [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support Jenny TC
2019-03-23 13:39 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570ed8a0-a83a-9da5-082a-2ce68a39d367@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=abhijeet.kumar@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=harshapriya.n@intel.com \
--cc=jenny.tc@intel.com \
--cc=jenny.tc@intel.corp-partner.google.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=naveen.m@intel.com \
--cc=perex@perex.cz \
--cc=rakesh.a.ughreja@intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=sriramx.periyasamy@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox