Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support
@ 2019-03-23 13:10 Jenny TC
  2019-03-23 13:39 ` Pierre-Louis Bossart
  0 siblings, 1 reply; 2+ messages in thread
From: Jenny TC @ 2019-03-23 13:10 UTC (permalink / raw)
  To: Pierre-Louis Bossart, alsa-devel, Liam Girdwood, Jie Yang,
	Mark Brown, Jaroslav Kysela, Takashi Iwai, Ughreja Rakesh A,
	Periyasamy SriramX, Kumar Abhijeet, Kale Sanyog R
  Cc: N Harshapriya, M Naveen, M R Sathya Prakash, Jenny TC,
	Nujella Sathyanarayana

From: Jenny TC <jenny.tc@intel.com>

To enable S24_LE format, sample_type in topology fw has to be set to 1.
But sample_type defined in topology firmware configuration is not
getting reflected in the dsp param. This patch sets sample_type in base
config so that the sample type defined in the topology firmware is reflected
in the dsp params. This issues was uncovered while debugging the S24_LE format
which require the MSB byte in 32 bit word to be skipped. Setting sample_type
in topology firmware to 1 helps to skip MSB byte word.

Signed-off-by: Jenny TC <jenny.tc@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index 28c4806..4bf70b4 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
 	base_cfg->audio_fmt.bit_depth = format->bit_depth;
 	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
 	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
+	base_cfg->audio_fmt.sample_type = format->sample_type;
 
 	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
 			format->bit_depth, format->valid_bit_depth,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support
  2019-03-23 13:10 [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support Jenny TC
@ 2019-03-23 13:39 ` Pierre-Louis Bossart
  0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2019-03-23 13:39 UTC (permalink / raw)
  To: Jenny TC, alsa-devel, Liam Girdwood, Jie Yang, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Ughreja Rakesh A,
	Periyasamy SriramX, Kumar Abhijeet, Kale Sanyog R
  Cc: N Harshapriya, M Naveen, M R Sathya Prakash, Jenny TC,
	Nujella Sathyanarayana

On 3/23/19 9:10 AM, Jenny TC wrote:
> From: Jenny TC <jenny.tc@intel.com>
> 
> To enable S24_LE format, sample_type in topology fw has to be set to 1.
> But sample_type defined in topology firmware configuration is not
> getting reflected in the dsp param. This patch sets sample_type in base
> config so that the sample type defined in the topology firmware is reflected
> in the dsp params. This issues was uncovered while debugging the S24_LE format
> which require the MSB byte in 32 bit word to be skipped. Setting sample_type
> in topology firmware to 1 helps to skip MSB byte word.
> 
> Signed-off-by: Jenny TC <jenny.tc@intel.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/skylake/skl-messages.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
> index 28c4806..4bf70b4 100644
> --- a/sound/soc/intel/skylake/skl-messages.c
> +++ b/sound/soc/intel/skylake/skl-messages.c
> @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
>   	base_cfg->audio_fmt.bit_depth = format->bit_depth;
>   	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
>   	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
> +	base_cfg->audio_fmt.sample_type = format->sample_type;
>   
>   	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
>   			format->bit_depth, format->valid_bit_depth,
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-23 13:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-23 13:10 [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support Jenny TC
2019-03-23 13:39 ` Pierre-Louis Bossart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox