From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Rander Wang" <rander.wang@intel.com>,
vkoul@kernel.org, "Bard Liao" <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: soundwire: call pm_runtime_resume() in component probe
Date: Fri, 17 Jun 2022 14:05:42 -0500 [thread overview]
Message-ID: <59c76ae6-6d97-cdd4-ce1f-020ddf54593b@linux.intel.com> (raw)
In-Reply-To: <ed329dca-48f7-16fd-96eb-337becd372d8@linux.intel.com>
>>> What this patch does it make sure that the bus is operation when the
>>> card is created. In usual cases, this is a no-op, this just helps with
>>> corner test cases. It's not plugging a major hole in the pm_runtime
>>> support, just fixing a programming sequence that was not tested before.
>>
>>> One possible objection is that we don't keep the reference and the bus
>>> active until all components are probed. I tried doing this at the ASoC
>>> core level, but that breaks all kinds of devices that have their own
>>> quirky way of dealing with pm_runtime - specifically HDaudio and HDMI.
>>> That's why I added this resume here.
>>
>>> Makes sense?
>>
>> Ish. Ugh, right. So it's not fixing anything really, it's mainly
>> papering over cracks where things are being missed. In any case it's
>> not doing any harm and it helps things for now.
>
> You got it right. There are additional patches that were sent to use
> pm_runtime_resume_and_get() on set_jack, and other clear cases that were
> missed, but this is more of a blanket "do not harm" resume in case codec
> drivers are missing something.
please wait for merges, we're chasing two regressions with nonsensical
mixer values
numid=5,iface=MIXER,name='PGA4.0 4 Master Capture Volume'
; type=BOOLEAN,access=rw---R--,values=2
: values=on,on
| dBscale-min=-50.00dB,step=1.00dB,mute=1
and a spurious log that we missed:
snd-soc-dummy snd-soc-dummy: Runtime PM usage count underflow!
next prev parent reply other threads:[~2022-06-17 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 21:08 [PATCH 0/2] ASoC: SOF/soundwire: use resume_and_get on component probe Pierre-Louis Bossart
2022-06-16 21:08 ` [PATCH 1/2] ASoC: SOF: pcm: use pm_resume_and_get() " Pierre-Louis Bossart
2022-06-16 21:08 ` [PATCH 2/2] ASoC: codecs: soundwire: call pm_runtime_resume() in " Pierre-Louis Bossart
2022-06-17 9:44 ` Mark Brown
2022-06-17 14:35 ` Pierre-Louis Bossart
2022-06-17 17:37 ` Mark Brown
2022-06-17 18:54 ` Pierre-Louis Bossart
2022-06-17 19:05 ` Pierre-Louis Bossart [this message]
2022-06-17 20:12 ` Pierre-Louis Bossart
2022-06-18 0:46 ` [PATCH 0/2] ASoC: SOF/soundwire: use resume_and_get on " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c76ae6-6d97-cdd4-ce1f-020ddf54593b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox