From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Rander Wang" <rander.wang@intel.com>,
vkoul@kernel.org, "Bard Liao" <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: soundwire: call pm_runtime_resume() in component probe
Date: Fri, 17 Jun 2022 10:44:50 +0100 [thread overview]
Message-ID: <YqxNEjG19K/RbbFM@sirena.org.uk> (raw)
In-Reply-To: <20220616210825.132093-3-pierre-louis.bossart@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Thu, Jun 16, 2022 at 04:08:25PM -0500, Pierre-Louis Bossart wrote:
> Make sure that the bus and codecs are pm_runtime active when the card
> is registered/created. This avoid timeouts when accessing registers.
> +static int max98373_sdw_probe(struct snd_soc_component *component)
> +{
> + int ret;
> +
> + ret = pm_runtime_resume(component->dev);
> + if (ret < 0 && ret != -EACCES)
> + return ret;
I'm not clear what the issue is here. Is something that's accessing the
registers forgetting to do a pm_runtime_get(), or doing that rather than
using pm_runtime_get_sync()? This doesn't feel safe or robust.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-17 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 21:08 [PATCH 0/2] ASoC: SOF/soundwire: use resume_and_get on component probe Pierre-Louis Bossart
2022-06-16 21:08 ` [PATCH 1/2] ASoC: SOF: pcm: use pm_resume_and_get() " Pierre-Louis Bossart
2022-06-16 21:08 ` [PATCH 2/2] ASoC: codecs: soundwire: call pm_runtime_resume() in " Pierre-Louis Bossart
2022-06-17 9:44 ` Mark Brown [this message]
2022-06-17 14:35 ` Pierre-Louis Bossart
2022-06-17 17:37 ` Mark Brown
2022-06-17 18:54 ` Pierre-Louis Bossart
2022-06-17 19:05 ` Pierre-Louis Bossart
2022-06-17 20:12 ` Pierre-Louis Bossart
2022-06-18 0:46 ` [PATCH 0/2] ASoC: SOF/soundwire: use resume_and_get on " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqxNEjG19K/RbbFM@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox