From: Alan Young <consult.awy@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] pcm: rate: Add capability to pass configuration node to plugins
Date: Thu, 9 Feb 2017 15:41:04 +0000 [thread overview]
Message-ID: <7715a537-722a-be54-6635-d92961b0e617@gmail.com> (raw)
In-Reply-To: <s5hy3xg8zkp.wl-tiwai@suse.de>
On 08/02/17 15:36, Takashi Iwai wrote:
> can't change the existing function definition. This will be broken
> once you mix the old version of plugin with the new system or vice
> versa.
I had concluded that changing the type signature was in this case safe.
There is no (public) declaration of _snd_pcm_rate_/xxx/_open() function
type and I think that passing unexpected additional parameters is a
function is always safe.
However ...
> Alternatively, try to provide another function
> _snd_pcm_rate_xxx_open_conf() or such. In addition, you should
> provide the old open function as is for now, too.
> Then the rate plugin can try to get and open via snd_dlobj_cache_get()
> for the open_conf at first, then fall back to the old open function.
I like this more. It is cleaner in some ways and avoids the need to bump
the version number.
I'll work up a revised patch.
Thanks,
Alan.
next prev parent reply other threads:[~2017-02-09 15:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:24 [PATCH] pcm_rate: Do not discard slave reported delay in status result Alan Young
2016-11-17 15:26 ` Alan Young
2016-11-17 16:47 ` Takashi Iwai
2016-11-17 16:51 ` Alan Young
2016-11-17 16:55 ` Takashi Iwai
2016-11-17 17:12 ` [PATCH RESEND] " Alan Young
2016-11-28 19:11 ` Takashi Iwai
2016-12-13 11:43 ` Alan Young
2016-12-13 11:49 ` Takashi Iwai
2016-12-13 13:05 ` Alan Young
2016-12-14 14:29 ` Takashi Iwai
2017-02-08 10:50 ` [PATCH] pcm: rate: Add capability to pass configuration node to plugins Alan Young
2017-02-08 15:36 ` Takashi Iwai
2017-02-09 15:41 ` Alan Young [this message]
2017-02-09 15:48 ` Alan Young
2017-02-13 17:20 ` [PATCH] [updated] " Alan Young
2017-02-14 7:08 ` Takashi Iwai
2017-02-14 7:30 ` Alan Young
2017-02-15 12:28 ` Alan Young
2017-02-17 16:53 ` Takashi Iwai
2017-02-17 17:44 ` Alan Young
2017-02-17 17:59 ` Takashi Iwai
2017-02-21 12:02 ` Alan Young
2017-02-21 12:39 ` Takashi Iwai
2017-02-21 14:34 ` Alan Young
2017-02-21 14:43 ` Takashi Iwai
2017-02-21 15:04 ` Alan Young
2017-02-21 15:14 ` Takashi Iwai
2017-02-21 15:24 ` Alan Young
2017-02-21 15:28 ` Takashi Iwai
2017-02-21 16:14 ` Alan Young
2017-02-21 21:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7715a537-722a-be54-6635-d92961b0e617@gmail.com \
--to=consult.awy@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox