From: Takashi Iwai <tiwai@suse.de>
To: Alan Young <Alan.Young@IEE.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] [updated] pcm: rate: Add capability to pass configuration node to plugins
Date: Tue, 21 Feb 2017 22:30:43 +0100 [thread overview]
Message-ID: <s5hk28jnse4.wl-tiwai@suse.de> (raw)
In-Reply-To: <de8d6e87-7ade-e395-ae42-6ccec938823b@IEE.org>
On Tue, 21 Feb 2017 17:14:29 +0100,
Alan Young wrote:
>
> On 21/02/17 15:28, Takashi Iwai wrote:
> > You forgot to call
> >
> > snd_pcm_free(pcm);
> > free(rate);
> >
> > before returning an error.
> Ah, ok. Updated patch.
>
> >From de90c659c98ae4dac7de6eb225b22147f56a3d1c Mon Sep 17 00:00:00 2001
> From: Alan Young <consult.awy@gmail.com>
> Date: Thu, 7 Apr 2016 09:15:04 +0100
> Subject: [PATCH] pcm: rate: Add capability to pass configuration node to
> plugins
>
> If a rate plugin uses a node (compound) instead of a plain string for
> its "converter", and that compound is not a simple string array, then
> the compound will be passed as an additional parameter to the new plugin
> open() function (SND_PCM_RATE_PLUGIN_CONF_ENTRY(XXX)). The previous
> open() function (SND_PCM_RATE_PLUGIN_ENTRY(XXX)) will be called if the
> CONF version is not found. It is up to the plugin to determine whether
> the presence of the conf parameter is mandatory.
>
> Signed-off-by: Alan Young <consult.awy@gmail.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-02-21 21:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:24 [PATCH] pcm_rate: Do not discard slave reported delay in status result Alan Young
2016-11-17 15:26 ` Alan Young
2016-11-17 16:47 ` Takashi Iwai
2016-11-17 16:51 ` Alan Young
2016-11-17 16:55 ` Takashi Iwai
2016-11-17 17:12 ` [PATCH RESEND] " Alan Young
2016-11-28 19:11 ` Takashi Iwai
2016-12-13 11:43 ` Alan Young
2016-12-13 11:49 ` Takashi Iwai
2016-12-13 13:05 ` Alan Young
2016-12-14 14:29 ` Takashi Iwai
2017-02-08 10:50 ` [PATCH] pcm: rate: Add capability to pass configuration node to plugins Alan Young
2017-02-08 15:36 ` Takashi Iwai
2017-02-09 15:41 ` Alan Young
2017-02-09 15:48 ` Alan Young
2017-02-13 17:20 ` [PATCH] [updated] " Alan Young
2017-02-14 7:08 ` Takashi Iwai
2017-02-14 7:30 ` Alan Young
2017-02-15 12:28 ` Alan Young
2017-02-17 16:53 ` Takashi Iwai
2017-02-17 17:44 ` Alan Young
2017-02-17 17:59 ` Takashi Iwai
2017-02-21 12:02 ` Alan Young
2017-02-21 12:39 ` Takashi Iwai
2017-02-21 14:34 ` Alan Young
2017-02-21 14:43 ` Takashi Iwai
2017-02-21 15:04 ` Alan Young
2017-02-21 15:14 ` Takashi Iwai
2017-02-21 15:24 ` Alan Young
2017-02-21 15:28 ` Takashi Iwai
2017-02-21 16:14 ` Alan Young
2017-02-21 21:30 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk28jnse4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Alan.Young@IEE.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox