From: Takashi Iwai <tiwai@suse.de>
To: Alan Young <Alan.Young@IEE.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH RESEND] pcm_rate: Do not discard slave reported delay in status result.
Date: Tue, 13 Dec 2016 12:49:18 +0100 [thread overview]
Message-ID: <s5hshpsgibl.wl-tiwai@suse.de> (raw)
In-Reply-To: <372cbe9d-2456-75e0-cdaf-056df21a4b31@IEE.org>
On Tue, 13 Dec 2016 12:43:04 +0100,
Alan Young wrote:
>
> Hi,
>
> Sorry for the delay. I too got sidetracked by other work.
>
> On 28/11/16 19:11, Takashi Iwai wrote:
> >> >@@ -1083,15 +1115,17 @@ static int snd_pcm_rate_status(snd_pcm_t *pcm, snd_pcm_status_t * status)
> >> > status->state = SND_PCM_STATE_RUNNING;
> >> > status->trigger_tstamp = rate->trigger_tstamp;
> >> > }
> >> >- snd_pcm_rate_sync_hwptr(pcm);
> >> >+ snd_pcm_rate_sync_hwptr0(rate, status->hw_ptr);
> > This can't work.
> >
> > I can fix it in my side, but OTOH, this made me wonder how you tested
> > the patch...
>
> Why do you think that cannot work? I am pretty sure it is working just
> fine for us but I am sure that it is possible that I have missed
> something.
Compare the argument you passed there and the function definition,
it's obvious :)
Takashi
next prev parent reply other threads:[~2016-12-13 11:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:24 [PATCH] pcm_rate: Do not discard slave reported delay in status result Alan Young
2016-11-17 15:26 ` Alan Young
2016-11-17 16:47 ` Takashi Iwai
2016-11-17 16:51 ` Alan Young
2016-11-17 16:55 ` Takashi Iwai
2016-11-17 17:12 ` [PATCH RESEND] " Alan Young
2016-11-28 19:11 ` Takashi Iwai
2016-12-13 11:43 ` Alan Young
2016-12-13 11:49 ` Takashi Iwai [this message]
2016-12-13 13:05 ` Alan Young
2016-12-14 14:29 ` Takashi Iwai
2017-02-08 10:50 ` [PATCH] pcm: rate: Add capability to pass configuration node to plugins Alan Young
2017-02-08 15:36 ` Takashi Iwai
2017-02-09 15:41 ` Alan Young
2017-02-09 15:48 ` Alan Young
2017-02-13 17:20 ` [PATCH] [updated] " Alan Young
2017-02-14 7:08 ` Takashi Iwai
2017-02-14 7:30 ` Alan Young
2017-02-15 12:28 ` Alan Young
2017-02-17 16:53 ` Takashi Iwai
2017-02-17 17:44 ` Alan Young
2017-02-17 17:59 ` Takashi Iwai
2017-02-21 12:02 ` Alan Young
2017-02-21 12:39 ` Takashi Iwai
2017-02-21 14:34 ` Alan Young
2017-02-21 14:43 ` Takashi Iwai
2017-02-21 15:04 ` Alan Young
2017-02-21 15:14 ` Takashi Iwai
2017-02-21 15:24 ` Alan Young
2017-02-21 15:28 ` Takashi Iwai
2017-02-21 16:14 ` Alan Young
2017-02-21 21:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hshpsgibl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Alan.Young@IEE.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox