Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
	Jeff Chua <jeff.chua.linux@gmail.com>
Subject: Re: [PATCH 0/5] rewrite snd_pcm_playback_silence() again
Date: Fri, 05 May 2023 11:22:48 +0200	[thread overview]
Message-ID: <871qjvjfo7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230505073813.1219175-1-perex@perex.cz>

On Fri, 05 May 2023 09:38:08 +0200,
Jaroslav Kysela wrote:
> 
> This is a split of changes for both patches (the first with the missing
> top-up mode + later fix with mixups) proposed by Oswald. The aim was to
> pick only real code changes.
> 
> Only the first two patches after revert fixes the current silencing issues.
> The last two are just cleanups with the extra optimization in the last patch
> moving the common code to a function.
> 
> Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> Cc: Jeff Chua <jeff.chua.linux@gmail.com>
> 
> Jaroslav Kysela (5):
>   ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
>   ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the
>     threshold mode
>   ALSA: pcm: fix playback silence - correct the incremental silencing
>   ALSA: pcm: playback silence - remove extra code
>   ALSA: pcm: playback silence - move silence variables updates to
>     separate function

Thanks, this makes it much easier to digest the whole changes!

I watch out for a while whether any objection comes up, then apply
patches in today -- or if we didn't reach to consensus, I'll pick up
only the first revert patch for 6.4-rc1, at least.


Takashi

      parent reply	other threads:[~2023-05-05  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  7:38 [PATCH 0/5] rewrite snd_pcm_playback_silence() again Jaroslav Kysela
2023-05-05  7:38 ` [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Jaroslav Kysela
2023-05-05  9:31   ` Takashi Iwai
2023-05-05  9:38     ` Oswald Buddenhagen
2023-05-05 10:44       ` Takashi Iwai
2023-05-05  7:38 ` [PATCH 2/5] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode Jaroslav Kysela
2023-05-05  7:38 ` [PATCH 3/5] ALSA: pcm: fix playback silence - correct the incremental silencing Jaroslav Kysela
2023-05-05  9:57   ` Takashi Iwai
2023-05-05 10:17     ` Oswald Buddenhagen
2023-05-05  7:38 ` [PATCH 4/5] ALSA: pcm: playback silence - remove extra code Jaroslav Kysela
2023-05-05  7:38 ` [PATCH 5/5] ALSA: pcm: playback silence - move silence variables updates to separate function Jaroslav Kysela
2023-05-05  9:22 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qjvjfo7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeff.chua.linux@gmail.com \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox