From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
Jeff Chua <jeff.chua.linux@gmail.com>
Subject: Re: [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
Date: Fri, 05 May 2023 11:31:16 +0200 [thread overview]
Message-ID: <87zg6ji0pn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230505073813.1219175-2-perex@perex.cz>
On Fri, 05 May 2023 09:38:09 +0200,
Jaroslav Kysela wrote:
>
> This reverts commit 9f656705c5faa18afb26d922cfc64f9fd103c38d.
>
> There is a regression (the top-up mode). Unfortunately, the patch
> provided from the author of this commit is not easy for the review.
>
> Keep the update and new comments in headers.
>
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Better to add Reported-by and the reference for the original thread
reporting the regression, as well as the Fixes tag.
I can cook up it by myself, too.
Takashi
next prev parent reply other threads:[~2023-05-05 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 7:38 [PATCH 0/5] rewrite snd_pcm_playback_silence() again Jaroslav Kysela
2023-05-05 7:38 ` [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Jaroslav Kysela
2023-05-05 9:31 ` Takashi Iwai [this message]
2023-05-05 9:38 ` Oswald Buddenhagen
2023-05-05 10:44 ` Takashi Iwai
2023-05-05 7:38 ` [PATCH 2/5] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode Jaroslav Kysela
2023-05-05 7:38 ` [PATCH 3/5] ALSA: pcm: fix playback silence - correct the incremental silencing Jaroslav Kysela
2023-05-05 9:57 ` Takashi Iwai
2023-05-05 10:17 ` Oswald Buddenhagen
2023-05-05 7:38 ` [PATCH 4/5] ALSA: pcm: playback silence - remove extra code Jaroslav Kysela
2023-05-05 7:38 ` [PATCH 5/5] ALSA: pcm: playback silence - move silence variables updates to separate function Jaroslav Kysela
2023-05-05 9:22 ` [PATCH 0/5] rewrite snd_pcm_playback_silence() again Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg6ji0pn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=jeff.chua.linux@gmail.com \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox