From: Takashi Iwai <tiwai@suse.de>
To: MadEnvel <envelsavinds@gmail.com>
Cc: tiwai@suse.com, rf@opensource.cirrus.com,
david.rhodes@cirrus.com, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound
Date: Thu, 04 Jul 2024 18:32:02 +0200 [thread overview]
Message-ID: <87a5ixi0e5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240701205516.22662-2-envelsavinds@gmail.com>
On Mon, 01 Jul 2024 22:55:16 +0200,
MadEnvel wrote:
>
> Signed-off-by: MadEnvel <envelsavinds@gmail.com>
The Signed-off-by tag has to be a real name for legal reasons.
Also, the empty patch description is always bad. Could you fill more
information here, as such found in your cover letter?
After correcting those, please resubmit (with Stefan's Reviewed-by tag
added).
Thanks!
Takashi
> ---
> sound/pci/hda/cs35l41_hda_property.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 51998d1c72ff..80c816922f78 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -128,8 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
> { "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> { "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> { "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> - { "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> - { "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> + { "17AA38C7", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
> + { "17AA38C8", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
> { "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
> { "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
> {}
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-07-04 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 20:55 [PATCH 0/1] Swapped l/r channels on ThinkBook 13x Gen4 MadEnvel
2024-07-01 20:55 ` [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound MadEnvel
2024-07-04 13:34 ` Stefan Binding (Opensource)
2024-07-04 16:32 ` Takashi Iwai [this message]
2025-05-28 8:00 ` xebesex817
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ixi0e5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=envelsavinds@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox