[PATCH 0/1] Swapped l/r channels on ThinkBook 13x Gen4

[PATCH 0/1] Swapped l/r channels on ThinkBook 13x Gen4

[MadEnvel]

Earlier commits introduced audio support for Lenovo ThinBook 13x Gen 4
that needed a patch due to missing _DSD config.
Unfortunately, it looks like the left and right channels in the config are swapped.
This patch fixes channel assignment. Tested on Lenovo ThinkBook 13x
Gen4.

MadEnvel (1):
  Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound

 sound/pci/hda/cs35l41_hda_property.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.45.2

[PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound

[MadEnvel]

Signed-off-by: MadEnvel <envelsavinds@gmail.com>
---
 sound/pci/hda/cs35l41_hda_property.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 51998d1c72ff..80c816922f78 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -128,8 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
 	{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
 	{ "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
-	{ "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
-	{ "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
+	{ "17AA38C7", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
+	{ "17AA38C8", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
 	{ "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
 	{ "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
 	{}
-- 
2.45.2

RE: [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound

[Stefan Binding (Opensource)]

Reviewed-by: Stefan Binding <sbinding@opensource.cirrus.com>

> -----Original Message-----
> From: MadEnvel <envelsavinds@gmail.com>
> Sent: Monday, July 1, 2024 9:55 PM
> To: tiwai@suse.com; rf@opensource.cirrus.com
> Cc: david.rhodes@cirrus.com; alsa-devel@alsa-project.org;
> patches@opensource.cirrus.com; MadEnvel <envelsavinds@gmail.com>
> Subject: [PATCH 1/1] Fix swapped left and right channels for Lenovo
ThinBook
> 13x Gen4 sound
> 
> Signed-off-by: MadEnvel <envelsavinds@gmail.com>
> ---
>  sound/pci/hda/cs35l41_hda_property.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> index 51998d1c72ff..80c816922f78 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -128,8 +128,8 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
>  	{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },
> 0, 1, -1, 0, 0, 0 },
> -	{ "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> -	{ "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
> CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> +	{ "17AA38C7", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT,
> CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
> +	{ "17AA38C8", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT,
> CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
>  	{ "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 },
> 0, 2, -1, 0, 0, 0 },
>  	{ "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 },
> 0, 2, -1, 0, 0, 0 },
>  	{}
> --
> 2.45.2

Re: [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound

[Takashi Iwai]

On Mon, 01 Jul 2024 22:55:16 +0200,
MadEnvel wrote:
> 
> Signed-off-by: MadEnvel <envelsavinds@gmail.com>

The Signed-off-by tag has to be a real name for legal reasons.
Also, the empty patch description is always bad.  Could you fill more
information here, as such found in your cover letter?

After correcting those, please resubmit (with Stefan's Reviewed-by tag
added).


Thanks!

Takashi

> ---
>  sound/pci/hda/cs35l41_hda_property.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 51998d1c72ff..80c816922f78 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -128,8 +128,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
>  	{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B7", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> -	{ "17AA38C7", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> -	{ "17AA38C8", 4, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT }, 0, 2, -1, 1000, 4500, 24 },
> +	{ "17AA38C7", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
> +	{ "17AA38C8", 4, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, 2, -1, 1000, 4500, 24 },
>  	{ "17AA38F9", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
>  	{ "17AA38FA", 2, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
>  	{}
> -- 
> 2.45.2
> 

Re: [PATCH 1/1] Fix swapped left and right channels for Lenovo ThinBook 13x Gen4 sound

[xebesex817]

It's great to see the attention to detail—swapped audio channels can definitely be a subtle but annoying issue. Good to know it's been tested on the ThinkBook 13x Gen4. Appreciate the quick patch to get everything aligned properly. https://ragdollhit.io/