* [PATCH v1] sound: seq: check struct system assignment problem
@ 2023-07-05 8:50 Minjie Du
2023-07-05 8:55 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Minjie Du @ 2023-07-05 8:50 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Minjie Du, Stephen Rothwell,
moderated list:SOUND, open list
Cc: opensource.kernel
make data->system.parm1 avoid double assignment.
but note writes "RT message with two parameters to UMP"
is one of assignment is for system.parm2?
I'm not sure, Could you help check it out?
Thank you!
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
sound/core/seq/seq_ump_convert.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
index eb1d86ff6..60e637149 100644
--- a/sound/core/seq/seq_ump_convert.c
+++ b/sound/core/seq/seq_ump_convert.c
@@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
unsigned char status)
{
data->system.status = status;
- data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
data->system.parm1 = event->data.control.value & 0x7f;
return 1;
}
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] sound: seq: check struct system assignment problem
2023-07-05 8:50 [PATCH v1] sound: seq: check struct system assignment problem Minjie Du
@ 2023-07-05 8:55 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-07-05 8:55 UTC (permalink / raw)
To: Minjie Du
Cc: Jaroslav Kysela, Takashi Iwai, Stephen Rothwell,
moderated list:SOUND, open list, opensource.kernel
On Wed, 05 Jul 2023 10:50:22 +0200,
Minjie Du wrote:
>
> make data->system.parm1 avoid double assignment.
> but note writes "RT message with two parameters to UMP"
> is one of assignment is for system.parm2?
Yes, that should be rather parm2.
Could you resubmit with that typo fix instead?
Thanks!
Takashi
> I'm not sure, Could you help check it out?
> Thank you!
>
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> sound/core/seq/seq_ump_convert.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
> index eb1d86ff6..60e637149 100644
> --- a/sound/core/seq/seq_ump_convert.c
> +++ b/sound/core/seq/seq_ump_convert.c
> @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
> unsigned char status)
> {
> data->system.status = status;
> - data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
> data->system.parm1 = event->data.control.value & 0x7f;
> return 1;
> }
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-05 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-05 8:50 [PATCH v1] sound: seq: check struct system assignment problem Minjie Du
2023-07-05 8:55 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox