Re: [PATCH v2 0/8] ALSA: emu10k1: add support for high-bitrate modes of E-MU cards

[Takashi Iwai <tiwai@suse.de>]

On Tue, 11 Jul 2023 12:15:31 +0200,
Oswald Buddenhagen wrote:
> 
> On Mon, Jul 10, 2023 at 05:06:36PM +0200, Takashi Iwai wrote:
> > On Fri, 30 Jun 2023 16:45:34 +0200,
> > Oswald Buddenhagen wrote:
> >> 
> >> This series is what all the work was about: support the "dual-/quad-pumped"
> >> modes of the E-MU cards.
> >> 
> >> Oswald Buddenhagen (8):
> >>   ALSA: emu10k1: introduce alternative E-MU D.A.S. mode
> >>   ALSA: emu10k1: improve mixer control naming in E-MU D.A.S. mode
> >>   ALSA: emu10k1: set the "no filtering" bits on PCM voices
> >>   ALSA: emu10k1: make playback in E-MU D.A.S. mode 32-bit
> >>   ALSA: add snd_ctl_add_locked()
> >>   ALSA: emu10k1: add support for 2x/4x word clocks in E-MU D.A.S. mode
> >>   ALSA: emu10k1: add high-rate capture in E-MU D.A.S. mode
> >>   ALSA: emu10k1: add high-rate playback in E-MU D.A.S. mode
> > 
> > I still can't agree with the basic design using the dynamic kctl
> > addition / deletion in kcontrol's put action.
> > 
> you are not being constructive. please provide specific, actionable
> responses to _all_ challenges/questions.

The fundamental idea to add / delete the kctls from the put callback
is unacceptable; as repeated many times, this is known to break
existing applications.  As long as you are sticking with this idea, it
can go further.  Please avoid it and use the (more or less) static
configuration instead.


thanks,

Takashi