* [PATCH] ALSA: scarlett2: Add missing check with firmware version control
@ 2023-10-27 10:01 Geoffrey D. Bennett
2023-10-27 10:34 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Geoffrey D. Bennett @ 2023-10-27 10:01 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
scarlett2_add_firmware_version_ctl() may return an error, but the
return value was not being checked. Add the missing check.
Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
---
sound/usb/mixer_scarlett2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
index f6d1fdfa88e1..9803f3e426c6 100644
--- a/sound/usb/mixer_scarlett2.c
+++ b/sound/usb/mixer_scarlett2.c
@@ -4424,6 +4424,8 @@ static int snd_scarlett2_controls_create(
/* Add firmware version control */
err = scarlett2_add_firmware_version_ctl(mixer);
+ if (err < 0)
+ return err;
/* Read volume levels and controls from the interface */
err = scarlett2_read_configs(mixer);
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 10:01 [PATCH] ALSA: scarlett2: Add missing check with firmware version control Geoffrey D. Bennett
2023-10-27 10:34 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox