From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, bard.liao@intel.com,
yung-chuan.liao@linux.intel.com, kevin-lu@ti.com, tiwai@suse.de,
baojun.xu@ti.com, soyer@irl.hu, Baojun.Xu@fpt.com, navada@ti.com,
v-po@ti.com
Subject: Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data
Date: Wed, 3 Apr 2024 13:04:50 +0300 [thread overview]
Message-ID: <Zg0pwtuQ9gfeXwxd@smile.fi.intel.com> (raw)
In-Reply-To: <20240402231300.362-1-shenghao-ding@ti.com>
On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote:
> fixed tas2781 calibrated data - pow was written into a wrong register.
fixed --> Fix
Fixes tag?
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
...
> + 0x17, 0x18, 0x18, 0x13, 0x18
> + 0x74, 0x0c, 0x14, 0x70, 0x7c
While at it, can you add a trailing comma?
It will help in case of extending this in the future.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-03 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 23:12 [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data Shenghao Ding
2024-04-03 10:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg0pwtuQ9gfeXwxd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=v-po@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox