* [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data
@ 2024-04-02 23:12 Shenghao Ding
2024-04-03 10:04 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2024-04-02 23:12 UTC (permalink / raw)
To: broonie
Cc: andriy.shevchenko, lgirdwood, perex, pierre-louis.bossart,
13916275206, alsa-devel, linux-kernel, liam.r.girdwood, bard.liao,
yung-chuan.liao, kevin-lu, tiwai, baojun.xu, soyer, Baojun.Xu,
navada, v-po, Shenghao Ding
fixed tas2781 calibrated data - pow was written into a wrong register.
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 48dae3339305..116821ae3cb3 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -514,10 +514,10 @@ static int tas2563_save_calibration(struct tasdevice_priv *tas_priv)
static void tas2781_apply_calib(struct tasdevice_priv *tas_priv)
{
static const unsigned char page_array[CALIB_MAX] = {
- 0x17, 0x18, 0x18, 0x0d, 0x18
+ 0x17, 0x18, 0x18, 0x13, 0x18
};
static const unsigned char rgno_array[CALIB_MAX] = {
- 0x74, 0x0c, 0x14, 0x3c, 0x7c
+ 0x74, 0x0c, 0x14, 0x70, 0x7c
};
unsigned char *data;
int i, j, rc;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data
2024-04-02 23:12 [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data Shenghao Ding
@ 2024-04-03 10:04 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2024-04-03 10:04 UTC (permalink / raw)
To: Shenghao Ding
Cc: broonie, lgirdwood, perex, pierre-louis.bossart, 13916275206,
alsa-devel, linux-kernel, liam.r.girdwood, bard.liao,
yung-chuan.liao, kevin-lu, tiwai, baojun.xu, soyer, Baojun.Xu,
navada, v-po
On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote:
> fixed tas2781 calibrated data - pow was written into a wrong register.
fixed --> Fix
Fixes tag?
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
...
> + 0x17, 0x18, 0x18, 0x13, 0x18
> + 0x74, 0x0c, 0x14, 0x70, 0x7c
While at it, can you add a trailing comma?
It will help in case of extending this in the future.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-03 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 23:12 [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data Shenghao Ding
2024-04-03 10:04 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox