From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: SOUND <alsa-devel@alsa-project.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"moderated list:SOUND - SOUND OPEN FIRMWARE \(SOF\) DRIVERS"
<sound-open-firmware@alsa-project.org>
Subject: Re: [Sound-open-firmware] SoF support for 8086:9d71?
Date: Wed, 13 Jan 2021 14:44:54 +0100 [thread overview]
Message-ID: <dc226baf-5e78-fe64-2816-83782529ad2e@linux.intel.com> (raw)
In-Reply-To: <CAAd53p7OHhqXDJDuEamXwfseXiUdGfDsJhNJbdUYo_4uoBdzdQ@mail.gmail.com>
On 1/13/2021 5:48 AM, Kai-Heng Feng wrote:
> On Tue, Jan 12, 2021 at 9:25 PM Amadeusz Sławiński
> <amadeuszx.slawinski@linux.intel.com> wrote:
>>
>> On 12/17/2020 9:25 AM, Kai-Heng Feng wrote:
>> (...)
>>>>>
>>>>> Can you try this instead, the dependencies are indeed wrong in the Makefile:
>>>>
>>>> Ok, compiling a kernel for user to test...
>>>
>>> Well, this happens:
>>> ERROR: modpost: "skl_dsp_set_dma_control"
>>> [sound/soc/intel/skylake/snd-soc-skl-ssp-clk.ko] undefined!
>>> make[1]: *** [scripts/Makefile.modpost:111: sound/Module.symvers] Error 1
>>> make[1]: *** Deleting file 'sound/Module.symvers'
>>> make: *** [Makefile:1709: modules] Error 2
>>>
>>> Kai-Heng
>>>
>>>>
>>>> Kai-Heng
>>>>
>>>>>
>>>>> diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
>>>>> index 4e0248d2accc..7c5038803be7 100644
>>>>> --- a/sound/soc/intel/Makefile
>>>>> +++ b/sound/soc/intel/Makefile
>>>>> @@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/
>>>>> # Platform Support
>>>>> obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/
>>>>> obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/
>>>>> -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/
>>>>> +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/
>>>>> obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/
>>>>>
>>>>> # Machine support
>>>>>
>>>>>
>>
>> Hi,
>>
>> what is the status of this issue?
>
> Still the same, unresolved.
>
>> Does it now work with usptream kernel?
>
> No it doesn't.
>
Can you try with following patch:
diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile
index 4e0248d2accc..7c5038803be7 100644
--- a/sound/soc/intel/Makefile
+++ b/sound/soc/intel/Makefile
@@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/
# Platform Support
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/
obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/
-obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/
+obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/
obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/
# Machine support
diff --git a/sound/soc/intel/skylake/Makefile
b/sound/soc/intel/skylake/Makefile
index dd39149b89b1..1c4649bccec5 100644
--- a/sound/soc/intel/skylake/Makefile
+++ b/sound/soc/intel/skylake/Makefile
@@ -7,7 +7,7 @@ ifdef CONFIG_DEBUG_FS
snd-soc-skl-objs += skl-debug.o
endif
-obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl.o
+obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += snd-soc-skl.o
#Skylake Clock device support
snd-soc-skl-ssp-clk-objs := skl-ssp-clk.o
prev parent reply other threads:[~2021-01-13 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 16:51 SoF support for 8086:9d71? Kai-Heng Feng
2020-12-14 19:33 ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-12-15 3:54 ` Kai-Heng Feng
2020-12-15 17:21 ` Pierre-Louis Bossart
2020-12-15 17:48 ` Amadeusz Sławiński
2020-12-15 17:53 ` Kai-Heng Feng
2020-12-15 17:59 ` Pierre-Louis Bossart
2020-12-16 3:55 ` Kai-Heng Feng
2020-12-17 8:25 ` Kai-Heng Feng
2021-01-12 13:25 ` Amadeusz Sławiński
[not found] ` <CAAd53p7OHhqXDJDuEamXwfseXiUdGfDsJhNJbdUYo_4uoBdzdQ@mail.gmail.com>
2021-01-13 13:44 ` Amadeusz Sławiński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc226baf-5e78-fe64-2816-83782529ad2e@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=kai.heng.feng@canonical.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox