From: "Matt Mullins" <mokomull@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Fwd: Problems with hda_intel, Santa Rosa, and suspend
Date: Thu, 5 Jul 2007 17:13:48 -0500 [thread overview]
Message-ID: <dfd4051f0707051513p697f22a2p4e34d9910f44f15e@mail.gmail.com> (raw)
In-Reply-To: <s5hvecz5cz3.wl%tiwai@suse.de>
After some hacking, I found that for some reason, something is calling
azx_send_cmd with nids much wider than 7 bits. This happens exactly
twice, once with nid=0x534c, and nid=0x8845. Both times, the verb is
0xf1c, and para=0x00. This clobbers parts of "val" in both
azx_single_send_cmd and azx_corb_send_cmd. I added the following code
to azx_send_cmd, and it works now:
if (!direct && (nid >> 7)) {
snd_printd(SFX "Uh oh, too wide an NID value. codec=0x%x,
direct=0x%x, nid=0x%x, verb=0x%x, para=0x%x\n", (codec->addr)&0xf,
direct, nid, verb, para);
return -EIO;
}
This outputs:
[136890.000388] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide an NID value. codec=0x0, direct=0x0,
nid=0x534c, verb=0xf1c, para=0x0
[136890.000393] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide an NID value. codec=0x0, direct=0x0,
nid=0x8845, verb=0xf1c, para=0x0
I do realize that the problem is not completely fixed, and we still
need to figure out what actually calls azx_send_cmd with the offending
parameters. However, I am now lost in a sea of function pointers...
And it still doesn't work after a suspend, and I get a handful more
"uh oh"s upon resume:
[ 3.942647] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x534c, verb=0x71c, para=0xff
[ 3.942658] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x534c, verb=0x71d, para=0xff
[ 3.942668] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x534c, verb=0x71e, para=0xff
[ 3.942678] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x534c, verb=0x71f, para=0xff
[ 3.942688] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x534c, verb=0xf1c, para=0x0
[ 3.942697] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x8845, verb=0x71c, para=0xff
[ 3.942707] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x8845, verb=0x71d, para=0xff
[ 3.942717] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x8845, verb=0x71e, para=0xff
[ 3.942727] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x8845, verb=0x71f, para=0xff
[ 3.942736] ALSA
/home/mmullins/Desktop/alsa/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644:
hda-intel: Uh oh, too wide a NID value. codec=0x0, direct=0x0, nid
=0x8845, verb=0xf1c, para=0x0
----
Matt Mullins
next prev parent reply other threads:[~2007-07-05 22:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dfd4051f0706161836xa191176ke10deff2868ad8d6@mail.gmail.com>
[not found] ` <200706171149.27547.rjw@sisk.pl>
[not found] ` <dfd4051f0706171355i7bc3d4b7qe9aee2acb904c8c@mail.gmail.com>
2007-06-18 0:35 ` Fwd: Problems with hda_intel, Santa Rosa, and suspend Matt Mullins
2007-06-18 0:49 ` Lee Revell
2007-06-18 1:59 ` Matt Mullins
2007-06-19 10:56 ` Takashi Iwai
[not found] ` <dfd4051f0706191354i679c5b82pd8d788dfb012df3d@mail.gmail.com>
2007-06-20 10:14 ` Takashi Iwai
2007-06-20 21:18 ` Matt Mullins
2007-06-21 10:29 ` Takashi Iwai
2007-06-22 20:31 ` Matt Mullins
2007-06-25 10:18 ` Takashi Iwai
[not found] ` <dfd4051f0706251316uf265b3dw9c069dc5f75ceedf@mail.gmail.com>
2007-06-25 20:17 ` Fwd: " Matt Mullins
2007-06-27 12:42 ` Takashi Iwai
2007-07-04 20:37 ` Matt Mullins
2007-07-05 11:03 ` Takashi Iwai
2007-07-05 22:13 ` Matt Mullins [this message]
2007-07-06 2:42 ` Matt Mullins
2007-07-06 9:32 ` Takashi Iwai
2007-07-06 15:46 ` Thorsten Leemhuis
2007-07-06 16:19 ` Takashi Iwai
2007-07-06 16:56 ` Thorsten Leemhuis
2007-07-09 12:52 ` Takashi Iwai
2007-07-09 15:09 ` Thorsten Leemhuis
2007-06-29 6:13 albox
2007-06-29 23:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd4051f0707051513p697f22a2p4e34d9910f44f15e@mail.gmail.com \
--to=mokomull@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox