From: "Matt Mullins" <mokomull@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Fwd: Problems with hda_intel, Santa Rosa, and suspend
Date: Thu, 5 Jul 2007 21:42:21 -0500 [thread overview]
Message-ID: <dfd4051f0707051942n699f69cava8a9d83b3bae5e1@mail.gmail.com> (raw)
In-Reply-To: <dfd4051f0707051513p697f22a2p4e34d9910f44f15e@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
Found what I think is the problem... patch_sigmatel.c set
spec->num_pins=14, yet spec->pin_nids pointed to stac9205_pin_nids,
which was an array of only 12 NIDs. That caused [total guess here]
either stac92xx_save_bios_config_regs or stac92xx_set_config_regs to
read past the end of the array and into an uninitialized area. I
changed the 14 to a 12, and it seems to work. The attached patch is
against the current Mercurial sources, but I made the similar change
to kernel 2.6.22-rc7, and it doesn't use single_cmd anymore. It still
doesn't work after a suspend, though, making me unload and reload the
module.
[-- Attachment #2: patch_mokomull --]
[-- Type: application/octet-stream, Size: 409 bytes --]
--- alsa-kernel-stock/pci/hda/patch_sigmatel.c 2007-07-05 20:44:46.000000000 -0500
+++ alsa-kernel/pci/hda/patch_sigmatel.c 2007-07-05 20:34:23.000000000 -0500
@@ -2259,7 +2259,7 @@
return -ENOMEM;
codec->spec = spec;
- spec->num_pins = 14;
+ spec->num_pins = 12;
spec->pin_nids = stac9205_pin_nids;
spec->board_config = snd_hda_check_board_config(codec, STAC_9205_MODELS,
stac9205_models,
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2007-07-06 2:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dfd4051f0706161836xa191176ke10deff2868ad8d6@mail.gmail.com>
[not found] ` <200706171149.27547.rjw@sisk.pl>
[not found] ` <dfd4051f0706171355i7bc3d4b7qe9aee2acb904c8c@mail.gmail.com>
2007-06-18 0:35 ` Fwd: Problems with hda_intel, Santa Rosa, and suspend Matt Mullins
2007-06-18 0:49 ` Lee Revell
2007-06-18 1:59 ` Matt Mullins
2007-06-19 10:56 ` Takashi Iwai
[not found] ` <dfd4051f0706191354i679c5b82pd8d788dfb012df3d@mail.gmail.com>
2007-06-20 10:14 ` Takashi Iwai
2007-06-20 21:18 ` Matt Mullins
2007-06-21 10:29 ` Takashi Iwai
2007-06-22 20:31 ` Matt Mullins
2007-06-25 10:18 ` Takashi Iwai
[not found] ` <dfd4051f0706251316uf265b3dw9c069dc5f75ceedf@mail.gmail.com>
2007-06-25 20:17 ` Fwd: " Matt Mullins
2007-06-27 12:42 ` Takashi Iwai
2007-07-04 20:37 ` Matt Mullins
2007-07-05 11:03 ` Takashi Iwai
2007-07-05 22:13 ` Matt Mullins
2007-07-06 2:42 ` Matt Mullins [this message]
2007-07-06 9:32 ` Takashi Iwai
2007-07-06 15:46 ` Thorsten Leemhuis
2007-07-06 16:19 ` Takashi Iwai
2007-07-06 16:56 ` Thorsten Leemhuis
2007-07-09 12:52 ` Takashi Iwai
2007-07-09 15:09 ` Thorsten Leemhuis
2007-06-29 6:13 albox
2007-06-29 23:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd4051f0707051942n699f69cava8a9d83b3bae5e1@mail.gmail.com \
--to=mokomull@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox