Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, 14545235@bugs.launchpad.net
Subject: Re: [PATCH] ALSA: hda - Disable Headphone Mic boost for ALC662
Date: Thu, 28 May 2015 09:18:40 +0200	[thread overview]
Message-ID: <s5h4mmxcgq7.wl-tiwai@suse.de> (raw)
In-Reply-To: <1432797346-2742-1-git-send-email-david.henningsson@canonical.com>

At Thu, 28 May 2015 09:15:46 +0200,
David Henningsson wrote:
> 
> When headphone mic boost is above zero, some 10 - 20 second delay
> might occur before the headphone mic is operational.
> Therefore disable the headphone mic boost control (recording gain is
> sufficient even without it).
> 
> (Note: this patch is not about the headset mic, it's about the less
> common mic-in only mode.)
> 
> BugLink: https://bugs.launchpad.net/bugs/1454235
> Suggested-by: Kailang Yang <kailang@realtek.com>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index d0fa455..87605fc 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4240,6 +4240,10 @@ static void alc_fixup_headset_mode_alc662(struct hda_codec *codec,
>  	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>  		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
>  		spec->gen.hp_mic = 1; /* Mic-in is same pin as headphone */
> +
> +		/* Disable boost for mic-in permanently */
> +		snd_hda_codec_write(codec, 0x1b, 0, AC_VERB_SET_AMP_GAIN_MUTE, 0x7000);
> +		snd_hda_override_wcaps(codec, 0x1b, get_wcaps(codec, 0x1b) & ~AC_WCAP_IN_AMP);

Can we really hard-code NID 0x1b here...?


Takashi

  reply	other threads:[~2015-05-28  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  7:15 [PATCH] ALSA: hda - Disable Headphone Mic boost for ALC662 David Henningsson
2015-05-28  7:18 ` Takashi Iwai [this message]
2015-05-28  7:25   ` David Henningsson
2015-05-28  7:30     ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2015-05-28  7:40 David Henningsson
2015-05-28  8:07 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4mmxcgq7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=14545235@bugs.launchpad.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox