Re: [PATCH] Volume control quirk for QuickCam E 3500

[Takashi Iwai <tiwai@suse.de>]

At Wed, 22 Jul 2009 14:18:33 +0200,
Alexey Fisher wrote:
> 
> - E3500 report cval->max more than it actually can handel, so if you
> set 95% capture level it will be silently muted.
> - Betwen cval->min and cval-max(real) is 2940 control units,
> but real are only 7 with cval->res = 384.
> - Alsa can't handel less than 10 controls, so make it more
> and set cval->res = 192.
> 
> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
> ---
>  sound/usb/usbmixer.c |   28 +++++++++++++++++++++++-----
>  1 files changed, 23 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
> index 5c48199..79e5b6d 100644
> --- a/sound/usb/usbmixer.c
> +++ b/sound/usb/usbmixer.c
> @@ -1000,20 +1000,38 @@ static void build_feature_ctl(struct mixer_build *state, unsigned char *desc,
>  		break;
>  	}
>  
> -	/* quirk for UDA1321/N101 */
> -	/* note that detection between firmware 2.1.1.7 (N101) and later 2.1.1.21 */
> -	/* is not very clear from datasheets */
> -	/* I hope that the min value is -15360 for newer firmware --jk */
> +	/* volume control quirks */
>  	switch (state->chip->usb_id) {
>  	case USB_ID(0x0471, 0x0101):
> +		break;
>  	case USB_ID(0x0471, 0x0104):
> +		break;
>  	case USB_ID(0x0471, 0x0105):
> +		break;

These three breaks are wrong.  It leads to skip the quirk for these
items.


Takashi