From: Takashi Iwai <tiwai@suse.de>
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH] Volume control quirk for QuickCam E 3500
Date: Wed, 22 Jul 2009 13:40:58 +0200 [thread overview]
Message-ID: <s5hfxcp0wtx.wl%tiwai@suse.de> (raw)
In-Reply-To: <4A66F857.9090309@fisher-privat.net>
At Wed, 22 Jul 2009 13:30:31 +0200,
Alexey Fisher wrote:
>
> Takashi Iwai schrieb:
> > At Wed, 22 Jul 2009 12:42:56 +0200,
> > Alexey Fisher wrote:
> >> - E3500 report cval->max more than it actually can handel, so if you
> >> set 95% capture level it will be silently muted.
> >> - Betwen cval->min and cval-max(real) is 2940 control units,
> >> but real are only 7 with cval->res = 384.
> >> - Alsa can't handel less than 10 controls, so make it more
> >> and set cval->res = 192.
> >>
> >> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
> >
> > They miss still break lines...
> > Could you fix it?
>
> Ok, i'll do every time checkpatch.pl. I promise :)
Ah, no, what I meant is to add "break;" line after each case in the
switch block...
Takashi
next prev parent reply other threads:[~2009-07-22 11:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 21:10 [PATCH] Mixer quirk for QuickCam E 3500 Alexey Fisher
2009-07-21 21:40 ` Takashi Iwai
2009-07-21 21:57 ` Alexey Fisher
2009-07-21 22:01 ` Takashi Iwai
2009-07-22 5:15 ` Alexey Fisher
2009-07-22 9:33 ` Takashi Iwai
2009-07-22 10:37 ` Alexey Fisher
2009-07-22 9:16 ` [PATCH] Volume control " Alexey Fisher
2009-07-22 9:32 ` Takashi Iwai
2009-07-22 10:42 ` Alexey Fisher
2009-07-22 10:44 ` Takashi Iwai
2009-07-22 11:28 ` Alexey Fisher
2009-07-22 11:30 ` Alexey Fisher
2009-07-22 11:40 ` Takashi Iwai [this message]
2009-07-22 12:18 ` Alexey Fisher
2009-07-22 12:47 ` Takashi Iwai
2009-07-22 12:57 ` Alexey Fisher
2009-07-22 14:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfxcp0wtx.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bug-track@fisher-privat.net \
--cc=clemens@ladisch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox