Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Matt Porter <mporter@embeddedalley.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] hda: add sigmatel dig mic support and refactor 9227
Date: Thu, 26 Oct 2006 13:02:30 +0200	[thread overview]
Message-ID: <s5hejsv7321.wl%tiwai@suse.de> (raw)
In-Reply-To: <20061025202110.GA351@matthew-porters-computer.local>

At Wed, 25 Oct 2006 16:21:10 -0400,
Matt Porter wrote:
> @@ -41,10 +41,8 @@
>  #define STAC_D945GTP3		1
>  #define STAC_D945GTP5		2
>  #define STAC_MACMINI		3
> -#define STAC_922X_MODELS	4	/* number of 922x models */
>  #define STAC_D965_3ST		4
>  #define STAC_D965_5ST		5
> -#define STAC_927X_MODELS	6	/* number of 922x models */

You cannot remove XXX_MODELS.
The size of *_brd_tbl[] must be defined as the max number of models.
Otherwise you might access to outside the array since the driver
checks the value of *_brd_tbl[model].

Also, some lines you added exceed 80-columns rule.  I know there are
still more lines over 80 chars,  but let's follow the standard coding
style at least for new codes.


Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2006-10-26 11:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 20:21 [PATCH] hda: add sigmatel dig mic support and refactor 9227 Matt Porter
2006-10-25 20:38 ` Lee Revell
2006-10-25 21:00   ` Matt Porter
2006-10-25 20:53 ` Tobin Davis
2006-10-25 21:41   ` Matt Porter
2006-10-25 22:32     ` Tobin Davis
2006-10-26 13:38   ` Matt Porter
2006-10-26 13:40     ` Takashi Iwai
2006-10-26 14:54       ` Tobin Davis
2006-10-26 15:08         ` Takashi Iwai
2006-10-26 11:02 ` Takashi Iwai [this message]
2006-10-26 14:36   ` Matt Porter
2006-10-26 15:03     ` Tobin Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hejsv7321.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mporter@embeddedalley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox