Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 3/3] ALSA: topology: Export ID types for TLV controls.
Date: Thu, 28 May 2015 16:59:35 +0200	[thread overview]
Message-ID: <s5hiobc7noo.wl-tiwai@suse.de> (raw)
In-Reply-To: <1432824456.2726.46.camel@loki>

At Thu, 28 May 2015 15:47:36 +0100,
Liam Girdwood wrote:
> 
> On Mon, 2015-05-25 at 18:22 +0100, Liam Girdwood wrote:
> > Make sure userspace can define TLV controls for topolofy using the correct
> > type numbers.
> > 
> > Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> > ---
> >  include/sound/tlv.h      |  7 +------
> >  include/uapi/sound/tlv.h | 23 +++++++++++++++++++++++
> >  2 files changed, 24 insertions(+), 6 deletions(-)
> >  create mode 100644 include/uapi/sound/tlv.h
> > 
> > diff --git a/include/sound/tlv.h b/include/sound/tlv.h
> 
> Takashi, do you want this rolled into uapi/sound/asound.h or is it fine
> as a separate file ?

I think uapi/sound/tlv.h is fine.

But don't forget to export other consts.  For example,
SNDRV_CTL_TLVT_CHMAP_* are also reserved for channel-maps.


thanks,

Takashi

  reply	other threads:[~2015-05-28 14:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 17:22 [PATCH v2 1/3] ASoC: topology: Add topology UAPI header Liam Girdwood
2015-05-25 17:22 ` [PATCH v2 2/3] ASoC: topology: Add topology core Liam Girdwood
2015-05-27 19:00   ` Mark Brown
2015-05-27 19:23     ` Lars-Peter Clausen
2015-05-27 19:48       ` Mark Brown
2015-05-28 14:45         ` Liam Girdwood
2015-05-28 15:23           ` Mark Brown
2015-05-28 14:33     ` Liam Girdwood
2015-05-29  5:57       ` Vinod Koul
2015-05-25 17:22 ` [PATCH v2 3/3] ALSA: topology: Export ID types for TLV controls Liam Girdwood
2015-05-28 14:47   ` Liam Girdwood
2015-05-28 14:59     ` Takashi Iwai [this message]
2015-05-26 10:33 ` [PATCH v2 1/3] ASoC: topology: Add topology UAPI header Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiobc7noo.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox