[PATCH] rawmidi: remove undefined functions.

[PATCH] rawmidi: remove undefined functions.

[Takashi Sakamoto]

'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared
but not defined.

This state has been continue over 10 years. So let us remove them.
---
 include/sound/rawmidi.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h
index adf0885..311dafe 100644
--- a/include/sound/rawmidi.h
+++ b/include/sound/rawmidi.h
@@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream,
 
 /* callbacks */
 
-void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
 			const unsigned char *buffer, int count);
-void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,
 			      unsigned char *buffer, int count);
-- 
1.8.3.2

Re: [PATCH] rawmidi: remove undefined functions.

[Takashi Iwai]

At Thu, 20 Feb 2014 23:59:24 +0900,
Takashi Sakamoto wrote:
> 
> 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared
> but not defined.
> 
> This state has been continue over 10 years. So let us remove them.

Could you give your sign-off?


thanks,

Takashi


> ---
>  include/sound/rawmidi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h
> index adf0885..311dafe 100644
> --- a/include/sound/rawmidi.h
> +++ b/include/sound/rawmidi.h
> @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream,
>  
>  /* callbacks */
>  
> -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
>  			const unsigned char *buffer, int count);
> -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,
>  			      unsigned char *buffer, int count);
> -- 
> 1.8.3.2
> 

Re: [PATCH] rawmidi: remove undefined functions.

[Takashi Sakamoto]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

> Could you give your sign-off?

Oops, I forgot it...
Would you use attached patch instead of previous one?

Thanks

Takashi Sakamoto
o-takashi@sakamocchi.jp


[-- Attachment #2: 0001-rawmidi-remove-undefined-functions.patch --]
[-- Type: text/x-patch, Size: 1228 bytes --]

>From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: Thu, 20 Feb 2014 23:45:39 +0900
Subject: [PATCH] rawmidi: remove undefined functions.

'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared
but not defined.

This state has been continue over 10 years. So let us remove them.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 include/sound/rawmidi.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h
index adf0885..311dafe 100644
--- a/include/sound/rawmidi.h
+++ b/include/sound/rawmidi.h
@@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream,
 
 /* callbacks */
 
-void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
 			const unsigned char *buffer, int count);
-void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream);
 int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,
 			      unsigned char *buffer, int count);
-- 
1.8.3.2


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] rawmidi: remove undefined functions.

[Takashi Iwai]

At Fri, 21 Feb 2014 11:18:57 +0900,
Takashi Sakamoto wrote:
> 
> >From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001
> From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Date: Thu, 20 Feb 2014 23:45:39 +0900
> Subject: [PATCH] rawmidi: remove undefined functions.
> 
> 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared
> but not defined.
> 
> This state has been continue over 10 years. So let us remove them.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied.


Takashi

> ---
>  include/sound/rawmidi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h
> index adf0885..311dafe 100644
> --- a/include/sound/rawmidi.h
> +++ b/include/sound/rawmidi.h
> @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream,
>  
>  /* callbacks */
>  
> -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
>  			const unsigned char *buffer, int count);
> -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,
>  			      unsigned char *buffer, int count);
> -- 
> 1.8.3.2
>