Re: [2.6 patch] ALSA: misc cleanups

Re: [2.6 patch] ALSA: misc cleanups

[Lee Revell]

On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote:
>   - sound/synth/emux/emux_synth.c: snd_emux_release_voice

Hmm, this should be used.  I will check it out.

>   - sound/synth/emux/soundfont.: snd_soundfont_mem_used

This one should be used also.

Lee





-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA: misc cleanups

[Takashi Iwai]

At Mon, 06 Dec 2004 13:44:10 -0500,
Lee Revell wrote:
> 
> On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote:
> >   - sound/synth/emux/emux_synth.c: snd_emux_release_voice
> 
> Hmm, this should be used.  I will check it out.
 
It's ok.  It's neither used nor exported.
Looks like an obsolete function.

> >   - sound/synth/emux/soundfont.: snd_soundfont_mem_used
> 
> This one should be used also.

It should be ok, too.  It's a one-line accessor, so the driver can
read the value directly from the struct instead.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: [2.6 patch] ALSA: misc cleanups

[Takashi Iwai]

At Mon, 6 Dec 2004 01:12:21 +0100,
Adrian Bunk wrote:
> 
> The patch below contains the following changes in ALSA code not touched 
> by my previous patches:
> - make some needlessly global code static
> - remove the following unused global functions:
>   - sound/i2c/cs84: snd_cs8427_detect
>   - sound/synth/emux/emux_synth.c: snd_emux_release_voice
>   - sound/synth/emux/soundfont.: snd_soundfont_mem_used
> - remove the following unused EXPORT_SYMBOL's:
>   - sound/i2c/cs8427.c: snd_cs8427_detect
>   - sound/i2c/cs8427.c: snd_cs8427_reg_read
> 
> Please review which of these changes are correct and which conflict with 
> pending patches.

All applied to the ALSA tree.  Thanks!


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/