* Re: [2.6 patch] ALSA: misc cleanups [not found] <20041206001221.GG2953@stusta.de> @ 2004-12-06 18:44 ` Lee Revell 2004-12-06 19:41 ` Takashi Iwai 2004-12-07 15:36 ` Takashi Iwai 1 sibling, 1 reply; 3+ messages in thread From: Lee Revell @ 2004-12-06 18:44 UTC (permalink / raw) To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote: > - sound/synth/emux/emux_synth.c: snd_emux_release_voice Hmm, this should be used. I will check it out. > - sound/synth/emux/soundfont.: snd_soundfont_mem_used This one should be used also. Lee ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [2.6 patch] ALSA: misc cleanups 2004-12-06 18:44 ` [2.6 patch] ALSA: misc cleanups Lee Revell @ 2004-12-06 19:41 ` Takashi Iwai 0 siblings, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2004-12-06 19:41 UTC (permalink / raw) To: Lee Revell; +Cc: Adrian Bunk, perex, alsa-devel, linux-kernel At Mon, 06 Dec 2004 13:44:10 -0500, Lee Revell wrote: > > On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote: > > - sound/synth/emux/emux_synth.c: snd_emux_release_voice > > Hmm, this should be used. I will check it out. It's ok. It's neither used nor exported. Looks like an obsolete function. > > - sound/synth/emux/soundfont.: snd_soundfont_mem_used > > This one should be used also. It should be ok, too. It's a one-line accessor, so the driver can read the value directly from the struct instead. Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] ALSA: misc cleanups [not found] <20041206001221.GG2953@stusta.de> 2004-12-06 18:44 ` [2.6 patch] ALSA: misc cleanups Lee Revell @ 2004-12-07 15:36 ` Takashi Iwai 1 sibling, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2004-12-07 15:36 UTC (permalink / raw) To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel At Mon, 6 Dec 2004 01:12:21 +0100, Adrian Bunk wrote: > > The patch below contains the following changes in ALSA code not touched > by my previous patches: > - make some needlessly global code static > - remove the following unused global functions: > - sound/i2c/cs84: snd_cs8427_detect > - sound/synth/emux/emux_synth.c: snd_emux_release_voice > - sound/synth/emux/soundfont.: snd_soundfont_mem_used > - remove the following unused EXPORT_SYMBOL's: > - sound/i2c/cs8427.c: snd_cs8427_detect > - sound/i2c/cs8427.c: snd_cs8427_reg_read > > Please review which of these changes are correct and which conflict with > pending patches. All applied to the ALSA tree. Thanks! Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-12-07 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20041206001221.GG2953@stusta.de>
2004-12-06 18:44 ` [2.6 patch] ALSA: misc cleanups Lee Revell
2004-12-06 19:41 ` Takashi Iwai
2004-12-07 15:36 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox