From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH 2/2] ALSA: firewire-lib: fix to process MIDI conformant data channel for AM824 format
Date: Fri, 28 Jun 2019 10:50:34 +0200 [thread overview]
Message-ID: <s5hpnmy6qlh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190628055331.1427-3-o-takashi@sakamocchi.jp>
On Fri, 28 Jun 2019 07:53:31 +0200,
Takashi Sakamoto wrote:
>
> In IEC 61883-6, 8 MIDI data streams are multiplexed into single MIDI
> conformant data channel. The index of stream is calculated by modulo 8
> of the value of data block counter. Therefore data block processing
> layer requires valid value of data block counter.
>
> In recent changes of ALSA IEC 61883-1/6 engine, the value of data block
> counter is changed before calling data block processing layer. This
> brings miss detection of MIDI messages in non-blocking transmission
> method is used.
>
> This commit fixes the bug by changing chached data block counter after
> calling data block processing layer.
>
> Fixes: e335425b6596 ("ALSA: firewire-lib: split helper function to check incoming CIP header")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2019-06-28 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 5:53 [PATCH 0/2] ALSA: firewire-lib: fix miss detection from MIDI conformant data channel in AM824 format for IR context Takashi Sakamoto
2019-06-28 5:53 ` [PATCH 1/2] ALSA: firewire-lib: cache next data_block_counter after probing tracepoints event " Takashi Sakamoto
2019-06-28 8:50 ` Takashi Iwai
2019-06-28 5:53 ` [PATCH 2/2] ALSA: firewire-lib: fix to process MIDI conformant data channel for AM824 format Takashi Sakamoto
2019-06-28 8:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpnmy6qlh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox